[AMQ-9469] Removed JRMS-1.1 dependency from assembly pom.xml#1191
Merged
Conversation
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
jbonofre
approved these changes
Apr 11, 2024
Contributor
Author
|
thank you @jbonofre! Two follow-up questions:
|
Member
|
Member
|
@kartg I cherry-picked the commit for |
Contributor
Author
|
Thank you! In future, would you prefer that requestors submit the backport PR so you don't have to manage it? Possibly useful - there's also a backport GH action which I've used on other projects that can automate backports based on labels. |
Member
|
@kartg we ask the contributor to open the PR on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jrms-1.1 library has not seen any releases/updates since 2005 and Maven lists only ActiveMQ and Apache Camel as upstream usages.
After digging through ActiveMQ's mailing lists and commit history, I found that it used to be listed on ActiveMQ's URI Protocols page, but was removed at some point. JRMS seems to be listed as a peer-to-peer option on the topologies page but is not discussed in either the peer or multicast transport reference pages.
The META-INF/services/org/apache/activemq/transport folder under
activemq-client(tested using v5.18.3) does not have a "jrms" file, so "jrms://" does not resolve to a supported ActiveMQ protocol.More details in the JIRA issue - https://issues.apache.org/jira/browse/AMQ-9469