fix(cli): prevent empty CLI files from overriding config-file files (#120)

benny123tw · web-flow · commit 4e42e3278f49 · 2026-05-07T18:07:07.000+09:00
diff --git a/src/cli/parse-args.ts b/src/cli/parse-args.ts
@@ -25,6 +25,18 @@ export async function parseArgs(): Promise<ParsedArgs> {
   try {
     const { args, resultArgs } = loadCliArgs()
 
+    // Strip a leading release type / version number from positional args before
+    // passing files to loadBumpConfig, so it doesn't override config-file `files`.
+    const rawFiles = [...(args['--'] || []), ...resultArgs]
+    let releaseFromArgs: string | undefined
+    if (rawFiles.length > 0) {
+      const firstArg = rawFiles[0]
+      if (firstArg === 'prompt' || isReleaseType(firstArg) || isValidVersion(firstArg)) {
+        releaseFromArgs = firstArg
+        rawFiles.shift()
+      }
+    }
+
     const parsedArgs: ParsedArgs = {
       help: args.help as boolean,
       version: args.version as boolean,
@@ -40,27 +52,17 @@ export async function parseArgs(): Promise<ParsedArgs> {
         confirm: args.yes === undefined ? undefined : !args.yes,
         noVerify: args.verify === undefined ? undefined : !args.verify,
         install: args.install,
-        files: [...(args['--'] || []), ...resultArgs],
+        files: rawFiles.length ? rawFiles : undefined,
         ignoreScripts: args.ignoreScripts,
         currentVersion: args.currentVersion,
         execute: args.execute,
         printCommits: args.printCommits,
         recursive: args.recursive,
-        release: args.release,
+        release: args.release ?? releaseFromArgs,
         configFilePath: args.configFilePath,
       }),
     }
 
-    // If a version number or release type was specified, then it will mistakenly be added to the "files" array
-    if (parsedArgs.options.files && parsedArgs.options.files.length > 0) {
-      const firstArg = parsedArgs.options.files[0]
-
-      if (firstArg === 'prompt' || isReleaseType(firstArg) || isValidVersion(firstArg)) {
-        parsedArgs.options.release = firstArg
-        parsedArgs.options.files.shift()
-      }
-    }
-
     if (parsedArgs.options.recursive && parsedArgs.options.files?.length)
       console.log(styleText('yellow', 'The --recursive option is ignored when files are specified'))
 
diff --git a/test/fixtures/bump.config.ts b/test/fixtures/bump.config.ts
@@ -0,0 +1,5 @@
+import { defineConfig } from '../../src'
+
+export default defineConfig({
+  files: ['custom.json', 'packages/**/package.json'],
+})
diff --git a/test/parse-args.test.ts b/test/parse-args.test.ts
@@ -97,3 +97,17 @@ describe('parseArgs (confirm regression fix)', () => {
     expect(options.confirm).toBe(true)
   })
 })
+
+describe('loadBumpConfig (files override fix #119)', () => {
+  const fixtureDir = new URL('./fixtures', import.meta.url).pathname
+
+  it('preserves config files when no CLI files are passed (files: undefined)', async () => {
+    const config = await loadBumpConfig({ files: undefined }, fixtureDir)
+    expect(config.files).toEqual(['custom.json', 'packages/**/package.json'])
+  })
+
+  it('overrides config files when CLI files are explicitly passed', async () => {
+    const config = await loadBumpConfig({ files: ['explicit.json'] }, fixtureDir)
+    expect(config.files).toEqual(['explicit.json'])
+  })
+})
