fix(config): prevent undefined overrides from overwriting defaults (#118)

kWAYTV · web-flow · commit 2b51d54e36f0 · 2026-03-16T15:14:17.000+09:00
diff --git a/src/config.ts b/src/config.ts
@@ -40,9 +40,17 @@ export async function loadBumpConfig(
     cwd,
   })
 
+  // Omit undefined overrides so they don't overwrite defaults (undefined = "use default")
+  const definedOverrides = overrides
+    ? Object.fromEntries(
+        Object.entries(overrides).filter(([, v]) => v !== undefined),
+      ) as Partial<VersionBumpOptions>
+    : {}
+
   return {
+    ...bumpConfigDefaults,
     ...config,
-    ...overrides,
+    ...definedOverrides,
   }
 }
 
diff --git a/test/parse-args.test.ts b/test/parse-args.test.ts
@@ -1,5 +1,6 @@
 import { describe, expect, it } from 'vitest'
-import { loadCliArgs } from '../src/cli/parse-args'
+import { loadCliArgs, parseArgs } from '../src/cli/parse-args'
+import { loadBumpConfig } from '../src/config'
 
 const defaultArgs = ['node', 'bumpp']
 
@@ -72,3 +73,27 @@ describe('loadCliArgs', async () => {
     expect(result.args.configFilePath).toBe('test/fixtures/build.config.ts')
   })
 })
+
+describe('loadBumpConfig (confirm regression fix)', () => {
+  it('preserves default confirm when overrides pass confirm: undefined', async () => {
+    const config = await loadBumpConfig({ confirm: undefined })
+    expect(config.confirm).toBe(true)
+  })
+
+  it('preserves default noGitCheck when overrides pass noGitCheck: undefined', async () => {
+    const config = await loadBumpConfig({ noGitCheck: undefined })
+    expect(config.noGitCheck).toBe(true)
+  })
+
+  it('applies explicit confirm: false when --yes would be passed', async () => {
+    const config = await loadBumpConfig({ confirm: false })
+    expect(config.confirm).toBe(false)
+  })
+})
+
+describe('parseArgs (confirm regression fix)', () => {
+  it('has confirm: true when run without --yes (prompts before bump)', async () => {
+    const { options } = await parseArgs()
+    expect(options.confirm).toBe(true)
+  })
+})
