fix(i18n): Correct spacing in copy message from '복사 됨' to '복사됨' in ko_KR.ts#55672
fix(i18n): Correct spacing in copy message from '복사 됨' to '복사됨' in ko_KR.ts#55672li-jia-nan merged 1 commit intoant-design:masterfrom rapsealk:fix/korean-locale-spacing
Conversation
|
|
👁 Visual Regression Report for PR #55672 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
Summary of ChangesHello @rapsealk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Korean localization by addressing a subtle but important grammatical detail in the 'copied' message. By removing a space, it ensures the translation adheres to proper Korean spacing rules for verb stem and nominalized form combinations, enhancing the linguistic accuracy and user experience for Korean speakers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
|
📝 WalkthroughSummary by CodeRabbit发行说明
概览韩文本地化字符串更新：将 变更
代码审查工作量估计🎯 1 (微小) | ⏱️ ~2 分钟
诗歌
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a spacing issue in the Korean translation for the 'copied' message. The change from '복사 됨' to '복사됨' is a proper application of Korean grammatical rules, as clearly explained in the pull request description. This is a good fix that improves the quality of the internationalization. The change is correct and I have no further suggestions.
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 6.32MB (186.72%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55672 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 776 776
Lines 14140 14140
Branches 3773 3773
=========================================
Hits 14140 14140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Follow-up of #40716.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
복사(하다) is a verb stem (“복사-”) and ‘-됨’ is the 명사형 어미 (-ㅁ) making “복사됨” a single nominalized form meaning “(has) been copied”.
According to the Korean spacing rule, because “복사됨” functions as one concept (“copied”), the noun form should be 붙여 쓴다, i.e., 복사됨.
Writing “복사 됨” would treat “복사” and “됨” as separate words, which is not consistent with the pattern of verb stem + 명사형 어미 forming one word.
📝 Change Log