fix: add missing childrenColumnName dependency by li-jia-nan · Pull Request #55559 · ant-design/ant-design

li-jia-nan · 2025-11-01T09:37:46Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	fix: add missing childrenColumnName dependency
🇨🇳 Chinese	fix: add missing childrenColumnName dependency

bolt-new-by-stackblitz · 2025-11-01T09:37:49Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-11-01T09:37:54Z

👁 Visual Regression Report for PR #55559 Passed ✅

🎯 Target branch: next (37966db)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2025-11-01T09:37:55Z

gemini-code-assist · 2025-11-01T09:37:56Z

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the InternalTable component by correctly including childrenColumnName in the dependency arrays of relevant useMemo hooks. This ensures that the table's internal calculations and memoized values are re-evaluated whenever the childrenColumnName prop changes, preventing inconsistencies and ensuring data integrity.

Highlights

Dependency Array Update: The childrenColumnName prop has been added to the dependency arrays of two React.useMemo hooks within the InternalTable.tsx component.
Bug Fix: This change resolves a potential bug where the table's internal state, particularly sorted data or other memoized values, might not update correctly if the childrenColumnName prop changed, leading to stale data or rendering issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2025-11-01T09:38:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch childrenColumnName-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request aims to fix a bug by adding the missing childrenColumnName dependency to useMemo hooks in InternalTable.tsx. The changes correctly identify that childrenColumnName is a dependency for calculating expandType and sortedData. While the fix for sortedData is correct, the one for expandType is incomplete as it's still missing other dependencies. I've left a comment with a suggestion to address this.

github-actions · 2025-11-01T09:41:03Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	495.38 KB
`dist/antd-with-locales.min.js`	587.53 KB (+1 B 🔺)

pkg-pr-new · 2025-11-01T09:41:45Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55559

commit: ae969a5

codecov · 2025-11-01T09:41:52Z

Bundle Report

Changes will increase total bundle size by 80 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	11.8MB	80 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js`	40 bytes	6.21MB	0.0%
`antd.js`	40 bytes	5.59MB	0.0%

cloudflare-workers-and-pages · 2025-11-01T09:43:56Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`ae969a5`
Status:	✅ Deploy successful!
Preview URL:	https://5b82e504.ant-design.pages.dev
Branch Preview URL:	https://childrencolumnname-fix.ant-design.pages.dev

View logs

cloudflare-workers-and-pages · 2025-11-01T09:45:14Z

Deploying ant-design-next with Cloudflare Pages

Latest commit:	`ae969a5`
Status:	✅ Deploy successful!
Preview URL:	https://e5fb0b00.ant-design-next.pages.dev
Branch Preview URL:	https://childrencolumnname-fix.ant-design-next.pages.dev

View logs

codecov · 2025-11-01T09:49:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (427379b) to head (ae969a5).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #55559   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          796       796           
  Lines        14690     14690           
  Branches      3899      3899           
=========================================
  Hits         14690     14690

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: 刘欢 <lh01217311@antgroup.com> Co-authored-by: lijianan <574980606@qq.com> Co-authored-by: 遇见同学 <1875694521@qq.com> Co-authored-by: thinkasany <480968828@qq.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: heming <984507092@qq.com> Co-authored-by: 海绵 <hai.mian@yingdao.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: binghui.dbh <binghui.dbh@antgroup.com> Co-authored-by: thinkasany <117748716+thinkasany@users.noreply.github.com> Co-authored-by: afc163 <507615+afc163@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ice <1597834867@qq.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: 叶文俊 <yewenjun@mistong.com> Co-authored-by: 二货爱吃白萝卜 <smith3816@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: EmilyyyLiu <100924403+EmilyyyLiu@users.noreply.github.com> Co-authored-by: zjr222 <67370334+zjr222@users.noreply.github.com> Co-authored-by: sheng zhang <79007994+Arktomson@users.noreply.github.com> Co-authored-by: MadCcc <madccc@foxmail.com> Co-authored-by: keda <53565274+Linkodt@users.noreply.github.com> Co-authored-by: divyeshagrawal <138372682+divyeshagrawal@users.noreply.github.com> Co-authored-by: xkhanhan <61129468+xkhanhan@users.noreply.github.com> Co-authored-by: tanjiahao24 <90695367+tanjiahao24@users.noreply.github.com> Co-authored-by: Susuper <susuperli@163.com> Co-authored-by: ccc1018 <82812268+ccc1018@users.noreply.github.com> Co-authored-by: GinWU <ginwu05@gmail.com> Co-authored-by: lts <lts.lyc@qq.com> Co-authored-by: nmsn <136696700@qq.com> Co-authored-by: elrrrrrrr <elrrrrrrr@gmail.com> Co-authored-by: 叶枫 <7971419+crazyair@users.noreply.github.com> Co-authored-by: Wanpan <wanpan96@163.com> Co-authored-by: 沐白 <13588781920@163.com> Co-authored-by: heming <74885943+984507092@users.noreply.github.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: Guo Yunhe <i@guoyunhe.me> fix popconfirm style (#55173) fix typo of pannel to panel (#55178) fix: leavedClassName classname when hidden (#55309) fix(timeline): add missing orientation memo deps (#55449) fix(collapse): add missing deps (#55452) fix(menu): add missing contextValue memo deps (#55459) fix: add splitter missing memo deps (#55486) resolve console.error (#55488) fix script (#55496) fix: semantic of collapse (#55499) fix: add divider missing memo deps (#55514) fix: add progress missing memo deps (#55554) fix: add tag useColor hooks missing memo deps (#55555) fix: add PromptDrawer missing memo deps (#55556) fix: add missing childrenColumnName dependency (#55559) fix: Optimize the definition of the duration type (#55580) fix(textarea): resize is invalid in styles.textarea (#55579) fix Dynamic demo key calculte error (#55624) fix: static css extract should order of Button (#55619) fix missing addon (#55784) fix: add missing dependency (#55782) fix: update innerLoading to loading (#55789)

fix: add missing childrenColumnName dependency

77f6e79

gemini-code-assist Bot reviewed Nov 1, 2025

View reviewed changes

Comment thread components/table/InternalTable.tsx

Merge branch 'next' into childrenColumnName-fix

ae969a5

thinkasany approved these changes Nov 1, 2025

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2025

thinkasany merged commit 91dde28 into next Nov 1, 2025
44 checks passed

thinkasany deleted the childrenColumnName-fix branch November 1, 2025 09:53

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

Uh oh!

Conversation

li-jia-nan commented Nov 1, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Nov 1, 2025

Uh oh!

github-actions Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55559 Passed ✅

Uh oh!

github-actions Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Nov 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

cloudflare-workers-and-pages Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design-next with Cloudflare Pages

Uh oh!

codecov Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Nov 1, 2025 •

edited

Loading

github-actions Bot commented Nov 1, 2025 •

edited

Loading

coderabbitai Bot commented Nov 1, 2025 •

edited

Loading

github-actions Bot commented Nov 1, 2025 •

edited

Loading

pkg-pr-new Bot commented Nov 1, 2025 •

edited

Loading

codecov Bot commented Nov 1, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Nov 1, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Nov 1, 2025 •

edited

Loading

codecov Bot commented Nov 1, 2025 •

edited

Loading