Conversation
|
|
👁 Visual Regression Report for PR #54182 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 10 diffs found in this PR: 🔄
|
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbit
Walkthrough本次变更大幅重构了 Alert、Anchor、AutoComplete 等组件，全面引入了对语义化 classNames 和 styles 的支持，允许开发者为组件各语义部分自定义类名和样式。同时，Alert 组件主内容属性由 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Alert
participant Anchor
participant AutoComplete
User->>Alert: 传入 classNames/styles、title、actions 等新属性
Alert->>Alert: 合并 context/props 的 classNames 和 styles
Alert->>Alert: 渲染语义结构（root, icon, section, title, ...）
User->>Anchor: 传入 classNames/styles
Anchor->>Anchor: 合并 context/props 的 classNames 和 styles
Anchor->>Anchor: 渲染语义结构（root, item, title, indicator）
User->>AutoComplete: 传入 classNames/styles
AutoComplete->>AutoComplete: 合并新旧 classNames/styles
AutoComplete->>AutoComplete: 渲染语义结构（root, input, popup...）
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying ant-design with
|
| Latest commit: |
8437e24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31d00c03.ant-design.pages.dev |
| Branch Preview URL: | https://alpha-test.ant-design.pages.dev |
|
别从官网移除啊，打个废弃标就好 |
size-limit report 📦
|
Bundle ReportBundle size has no change ✅ |
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #54182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 789 789
Lines 14406 14409 +3
Branches 3806 3808 +2
=========================================
+ Hits 14406 14409 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
你好，方便说下为什么要废弃 List 组件吗？ 该组件作为文章列表、消息列表、商品列表展示都挺方便的，但是集成了 pagination 和 grid 可能会有点冗余。 希望可以保留该组件，并简化 items 配置项。 |
|
@zombieJ PR 最好关联一下原始讨论文档，不然用户一看没头没尾的。 |
@aojunhao123 来补充一份原因吧。 大致原因是因为会提供一个新的 listy 组件，来增强 list 的功能和样式 |
|
antd v6 中会提供一个新的Listy组件，它会内置虚拟滚动能力，以及更加侧重于布局能力，便于开发者根据不同的业务场景更好的进行自定义。目前是在rc侧开发了rc-listy(目前是开发完成，等待豆酱老师review后再做具体调整)，后续antd也会在rc基础上提供一个Listy组件 |
English translation: "A new Listy component will be provided, which will have built-in virtual scrolling capabilities and a more focused layout capabilities, making it easier for developers to better customize according to different business scenarios. Currently, rc-listy has been developed on the rc side (the development is currently completed, and specific adjustments will be made after review). In the future, antd will also provide a Listy component based on rc" |
|
@zombieJ , When can we expect listy to be released? It's not a great strategy to deprecate a major component before a replacement exists. |
This PR update Antd from version 5 to v6. For the most part everything just works. I followed the [official migration guide](https://ant.design/docs/react/migration-v6) and fixed all deprecation warnings that I encountered. High level overview: - Updated `antd` to version `6.1.0` - Updated `@ant-design/icons` and `@ant-design/colors` to match - Updated deprecated and renamed prop names for components, e.g. `<Alert message={...}>` --> `<Alert title={...}`> - Updated the DOM structure of several component to use antd's `<Space>` or `<Flex>` for more uniform layouting instead of our wild mix of margin, paddings, custom stuff... ### Dev Instance https://antdv6.webknossos.xyz/ ### Steps to test: - I clicked through all the views, modals etc and looked for visual regressions. - I did deep testing with Chrome on Mac. Lighter testing with Safari and FireFox ### TODOs: - [x] Fix navbar dropdown menu - [x] Fix Dashboard > Dataset Table can be scrolled out of frame/parent container ### Follow Ups - [ ] Poor contrast for `<Tag>` close button in dark mode - [ ] `<List>` component is deprecated but the new replacement is not yet ready but [still under development](ant-design/ant-design#54182 (comment)). ### Issues: - fixes #9115 ------ (Please delete unneeded items, merge only when none are left open) - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [ ] Added migration guide entry if applicable (edit the same file as for the changelog) - [ ] Updated [documentation](../blob/master/docs) if applicable - [ ] Adapted [wk-libs python client](https://github.com/scalableminds/webknossos-libs/tree/master/webknossos/webknossos/client) if relevant API parts change - [ ] Removed dev-only changes like prints and application.conf edits - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md) - [ ] Needs datastore update after deployment --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
listy上都没上，就标记废弃，着啥急呢？新菜还没端上来就嚷嚷要撤盘了么。。。 |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log