Skip to content

refactor(space): support separator and deprecate split#53983

Merged
thinkasany merged 2 commits intonextfrom
space-separator
Jun 3, 2025
Merged

refactor(space): support separator and deprecate split#53983
thinkasany merged 2 commits intonextfrom
space-separator

Conversation

@thinkasany
Copy link
Copy Markdown
Member

@thinkasany thinkasany commented Jun 3, 2025

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 🛠 Refactoring
  • 🎨 Code style optimization

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English refactor(space): support separator and deprecate split
🇨🇳 Chinese 支持separator 并废弃 split

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Jun 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025 •
edited
Loading

Preview is ready

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025 •
edited by thinkasany
Loading

👁 Visual Regression Report for PR #53983 Failed ❌

🎯 Target branch: next (b1467d6)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🛑 3 removed, 🆕 3 added

Expected (Branch next) Actual (Current PR) Diff
space-split.compact.png space-split.compact.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
space-split.dark.png space-split.dark.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
space-split.default.png space-split.default.png ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
space-separator.compact.png space-separator.compact.png 🆕🆕🆕 Added 🆕🆕🆕
space-separator.dark.png space-separator.dark.png 🆕🆕🆕 Added 🆕🆕🆕
space-separator.default.png space-separator.default.png 🆕🆕🆕 Added 🆕🆕🆕

Important

There are 6 diffs found in this PR: 🛑 3 removed, 🆕 3 added.
Please check all items:

  • Visual diff is acceptable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 499.3 KB (+41 B 🔺)
dist/antd-with-locales.min.js 591.13 KB (+38 B 🔺)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 3, 2025 •
edited
Loading

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53983

commit: 7fca91e

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 7.77MB (207.13%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.53MB 7.77MB (207.13%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js (New) 6.07MB 6.07MB 100.0% 🚀
antd.js (New) 5.46MB 5.46MB 100.0% 🚀
antd-with-locales.min.js (Deleted) -2.07MB 0 bytes -100.0% 🗑️
antd.min.js (Deleted) -1.69MB 0 bytes -100.0% 🗑️

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 3, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7fca91e
Status: ✅  Deploy successful!
Preview URL: https://1c34f9bf.ant-design.pages.dev
Branch Preview URL: https://space-separator.ant-design.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b1467d6) to head (7fca91e).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff            @@
##              next    #53983   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          788       788           
  Lines        14334     14339    +5     
  Branches      3787      3788    +1     
=========================================
+ Hits         14334     14339    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 3, 2025
@thinkasany thinkasany merged commit 6b2e46f into next Jun 3, 2025
43 of 44 checks passed
@thinkasany thinkasany deleted the space-separator branch June 3, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkasany @zombieJ