refactor: Rename Steps labelPlacement to titlePlacement#53873
Merged
thinkasany merged 2 commits intonextfrom May 20, 2025
Merged
refactor: Rename Steps labelPlacement to titlePlacement#53873thinkasany merged 2 commits intonextfrom
thinkasany merged 2 commits intonextfrom
Conversation
|
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
👁 Visual Regression Report for PR #53873 Failed ❌
Important There are 6 diffs found in this PR: 🛑
|
Contributor
|
|
WalkthroughThis pull request refactors the Changes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Contributor
size-limit report 📦
|
thinkasany
reviewed
May 20, 2025
Comment on lines
325
to
329
|
|
||
| warning.deprecated(!labelPlacement, 'labelPlacement', 'titlePlacement'); | ||
| warning.deprecated(!progressDot, 'progressDot', 'type="dot"'); | ||
| warning.deprecated(!direction, 'direction', 'orientation'); | ||
| warning.deprecated( |
Member
There was a problem hiding this comment.
看起来可以和其他地方的 warning 一样用数组或者对象
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 44 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Deploying ant-design with
|
| Latest commit: |
f483cae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ef18d3a.ant-design.pages.dev |
| Branch Preview URL: | https://steps-label-placement.ant-design.pages.dev |
MadCcc
approved these changes
May 20, 2025
thinkasany
approved these changes
May 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #53873 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 788 788
Lines 14304 14305 +1
Branches 3784 3784
=========================================
+ Hits 14304 14305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
#53328
📝 Change Log
labelPlacementtotitlePlacementto unify the API.labelPlacement为titlePlacement以统一 API。