fix: Table sticky header render blink bug by afc163 · Pull Request #53803 · ant-design/ant-design

afc163 · 2025-05-12T06:17:37Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

fix #49099

fix #45964

close #53802

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

react-component/table#1267

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Fix Table header blink issue when sticky is enable.
🇨🇳 Chinese	修复 Table 开启 `sticky` 时的一个列头渲染闪烁问题。

bolt-new-by-stackblitz · 2025-05-12T06:17:40Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-05-12T06:17:44Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

components/table/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

Chores
- 更新了依赖项“rc-table”的版本至 ~7.50.5。

Walkthrough

此次更改仅更新了 package.json 文件中 rc-table 依赖的版本，从 ~7.50.4 升级到 ~7.50.5，未涉及其他文件或导出实体的变动。

Changes

文件/分组	变更摘要
package.json	将 `rc-table` 依赖版本从 `~7.50.4` 升级到 `~7.50.5`

Assessment against linked issues

Objective	Addressed	Explanation
修复使用 sticky 和 sorter 时，React 18 下通过 useEffect 设置 columns 导致表头 title 闪烁的问题 (#49099)	✅

Suggested labels

skip-verify-files

Suggested reviewers

zombieJ

Poem

小兔子跳跃来升级，
rc-table 版本更上一层，
闪烁表头已不再，
体验顺滑如春风。
代码轻盈如兔影，
一行变更，安静无声。
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-12T06:17:49Z

github-actions · 2025-05-12T06:17:49Z

👁 Visual Regression Report for PR #53803 Failed ❌

🎯 Target branch: master (f8ea8c6)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 36 changed

Expected (Branch master)	Actual (Current PR)	Diff
statistic-timer.compact.png	statistic-timer.compact.png
statistic-timer.compact.png	statistic-timer.compact.css-var.png
statistic-timer.dark.png	statistic-timer.dark.png
statistic-timer.dark.png	statistic-timer.dark.css-var.png
statistic-timer.default.png	statistic-timer.default.png
statistic-timer.default.png	statistic-timer.default.css-var.png
table-fixed-columns-header.compact.png	table-fixed-columns-header.compact.png
table-fixed-columns-header.compact.png	table-fixed-columns-header.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 36 diffs found in this PR: 🔄 36 changed.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

petercat-assistant · 2025-05-12T06:17:49Z

Walkthrough

This pull request addresses a bug fix for the Ant Design Table component, specifically resolving a rendering issue where the table header would blink when the sticky header feature was enabled. The fix involves updating the rc-table dependency to version ~7.50.5.

Changes

File	Summary
package.json	Updated `rc-table` dependency from `~7.50.4` to `~7.50.5` to fix the sticky header rendering issue.

socket-security · 2025-05-12T06:19:05Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	react-router-dom@7.6.0
	spinnies@0.5.1
	xhr-mock@2.5.1
	regenerator-runtime@0.14.1
	vanilla-tilt@1.8.1
	react-sticky-box@2.0.5
	runes2@1.1.4
	react-resizable@3.0.5
	react-fast-marquee@1.6.5
	size-limit@11.2.0
	react-infinite-scroll-component@6.1.0
	react-draggable@4.4.6
	tsx@4.19.4
	remark-cli@12.0.1
	rimraf@6.0.1
	remark@15.0.1
	react-countup@6.5.3
	remark-gfm@4.0.1
	tar@7.4.3
See 17 more rows in the dashboard

View full report

github-actions · 2025-05-12T06:20:19Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	451.22 KB
`dist/antd-with-locales.min.js`	538.77 KB

pkg-pr-new · 2025-05-12T06:21:06Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53803

commit: 2f30f01

codecov · 2025-05-12T06:21:14Z

Bundle Report

Changes will increase total bundle size by 48 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.4MB	48 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	24 bytes	1.86MB	0.0%
`antd.min.js`	24 bytes	1.55MB	0.0%

cloudflare-workers-and-pages · 2025-05-12T06:23:08Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`2f30f01`
Status:	✅ Deploy successful!
Preview URL:	https://0186cc0b.ant-design.pages.dev
Branch Preview URL:	https://test-table-snapshot.ant-design.pages.dev

View logs

codecov · 2025-05-12T06:38:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f8ea8c6) to head (2f30f01).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master    #53803   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          774       774           
  Lines        14005     14005           
  Branches      3705      3705           
=========================================
  Hits         14005     14005

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fix: Table sticky header render issue

de7c692

petercat-assistant Bot reviewed May 12, 2025

View reviewed changes

Comment thread package.json

coderabbitai Bot requested a review from zombieJ May 12, 2025 06:17

coderabbitai Bot added the skip-verify-files label May 12, 2025

fix snapshot

2f30f01

zombieJ approved these changes May 12, 2025

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label May 12, 2025

li-jia-nan approved these changes May 12, 2025

View reviewed changes

afc163 changed the title ~~fix: Table sticky header render issue~~ fix: Table sticky header render blink bug May 12, 2025

afc163 merged commit 3f9244b into master May 12, 2025
50 checks passed

afc163 deleted the test/table-snapshot branch May 12, 2025 06:47

EmilyyyLiu pushed a commit to EmilyyyLiu/ant-design that referenced this pull request May 15, 2025

fix: Table sticky header render blink bug (ant-design#53803)

ce3c4dd

PeachScript mentioned this pull request May 19, 2025

docs: changelog for 5.25.2 #53867

Merged

17 tasks

coderabbitai Bot mentioned this pull request Sep 1, 2025

fix: Table issues by upgrade rc-table to 7.52.5 #54824

Merged

17 tasks

afc163 mentioned this pull request Sep 2, 2025

在 next 中使用 Table 的 sticky中的offsetHeader有问题 #45964

Closed

coderabbitai Bot mentioned this pull request Sep 22, 2025

fix: Tour positioning when the target is a Table with fixed headers #55124

Merged

17 tasks

Uh oh!

Conversation

afc163 commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented May 12, 2025

Uh oh!

coderabbitai Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Summary by CodeRabbit

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 12, 2025 • edited by afc163 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53803 Failed ❌

Uh oh!

petercat-assistant Bot commented May 12, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

socket-security Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

pkg-pr-new Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

cloudflare-workers-and-pages Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

afc163 commented May 12, 2025 •

edited

Loading

coderabbitai Bot commented May 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented May 12, 2025 •

edited

Loading

github-actions Bot commented May 12, 2025 •

edited by afc163

Loading

socket-security Bot commented May 12, 2025 •

edited

Loading

github-actions Bot commented May 12, 2025 •

edited

Loading

pkg-pr-new Bot commented May 12, 2025 •

edited

Loading

codecov Bot commented May 12, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 12, 2025 •

edited

Loading

codecov Bot commented May 12, 2025 •

edited

Loading