feat(time-picker/date-picker): support popup semantic dom by aojunhao123 · Pull Request #53718 · ant-design/ant-design

aojunhao123 · 2025-05-03T17:04:29Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	🆕 DatePicker/TimePicker component adds popup semantic node, and deprecated some api
🇨🇳 Chinese	🆕 DatePicker/TimePicker 组件新增 popup 语义节点，并且废弃部分api

bolt-new-by-stackblitz · 2025-05-03T17:04:32Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-05-03T17:04:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-03T17:04:40Z

👁 Visual Regression Report for PR #53718 Failed ❌

🎯 Target branch: feature (10e93e5)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 6 changed

Expected (Branch feature)	Actual (Current PR)	Diff
statistic-timer.compact.png	statistic-timer.compact.png
statistic-timer.compact.png	statistic-timer.compact.css-var.png
statistic-timer.dark.png	statistic-timer.dark.png
statistic-timer.dark.png	statistic-timer.dark.css-var.png
statistic-timer.default.png	statistic-timer.default.png
statistic-timer.default.png	statistic-timer.default.css-var.png

Important

There are 6 diffs found in this PR: 🔄 6 changed.
Please check all items:

Visual diff is acceptable

github-actions · 2025-05-03T17:04:42Z

petercat-assistant · 2025-05-03T17:04:57Z

Walkthrough

This pull request introduces a new feature to the DatePicker and TimePicker components by adding support for popup semantic DOM. It also deprecates some existing APIs, such as popupClassName and popupStyle, replacing them with classNames.popup.root and styles.popup.root respectively. This change aims to enhance the semantic structure of the components' popups.

Changes

Files	Summary
components/date-picker/tests/DatePicker.test.tsx, components/date-picker/tests/RangePicker.test.tsx	Updated tests to reflect deprecation of `popupClassName` and `popupStyle`, and added new tests for the updated API.
components/date-picker/demo/_semantic.tsx, components/time-picker/demo/_semantic.tsx	Added new demo files to showcase the semantic DOM feature.
components/date-picker/generatePicker/generateRangePicker.tsx, components/date-picker/generatePicker/generateSinglePicker.tsx	Refactored to use new `classNames` and `styles` props for popup customization.
components/date-picker/generatePicker/interface.ts	Updated interface to include new `classNames` and `styles` props, and marked old props as deprecated.
components/date-picker/index.en-US.md, components/date-picker/index.zh-CN.md, components/time-picker/index.en-US.md, components/time-picker/index.zh-CN.md	Updated documentation to reflect changes in API and added a section for semantic DOM.
components/time-picker/demo/colored-popup.tsx	Updated demo to use new `classNames` prop for popup customization.

pkg-pr-new · 2025-05-03T17:07:55Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53718

commit: 7f67dc7

codecov · 2025-05-03T17:08:03Z

Bundle Report

Changes will increase total bundle size by 6.3MB (185.37%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
antd.min-array-push	9.7MB	6.3MB (185.37%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js` (New)	5.1MB	5.1MB	100.0% 🚀
`antd.js` (New)	4.59MB	4.59MB	100.0% 🚀
~~`antd-with-locales.min.js`~~ (Deleted)	-1.85MB	0 bytes	-100.0% 🗑️
~~`antd.min.js`~~ (Deleted)	-1.54MB	0 bytes	-100.0% 🗑️

Files in antd-with-locales.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.js:

./components/config-provider/context.ts → Total Size: 1.51kB

codecov · 2025-05-03T17:22:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (08e4902) to head (7f67dc7).
Report is 3 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #53718   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          772       774    +2     
  Lines        13954     14008   +54     
  Branches      3692      3706   +14     
=========================================
+ Hits         13954     14008   +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thinkasany · 2025-05-07T02:06:24Z

li-jia-nan · 2025-09-14T11:06:34Z

这个为啥不放在 next 分支？

thinkasany · 2025-09-14T11:19:18Z

这个为啥不放在 next 分支？

正式全部功能的话是在next的，feature 分支仅开启了 root

feat(time-picker/date-picker): support semantic dom

f8a2505

petercat-assistant Bot reviewed May 3, 2025

View reviewed changes

Comment thread components/date-picker/generatePicker/generateRangePicker.tsx

petercat-assistant Bot reviewed May 3, 2025

View reviewed changes

Comment thread components/date-picker/generatePicker/generateSinglePicker.tsx

thinkasany reviewed May 6, 2025

View reviewed changes

Comment thread components/time-picker/index.zh-CN.md

thinkasany reviewed May 6, 2025

View reviewed changes

Comment thread components/date-picker/demo/_semantic.tsx Outdated

aojunhao123 added 3 commits May 7, 2025 03:50

refactor code

43f6e35

Merge branch 'feature' into semantic-dom-picker

f3f67eb

docs update

c0e16e3

aojunhao123 added 3 commits May 7, 2025 12:52

test: add test case

c1f806e

fix: test coverage

bb11975

fix: test coverage

4c3c2d6

thinkasany reviewed May 7, 2025

View reviewed changes

Comment thread components/date-picker/generatePicker/generateSinglePicker.tsx Outdated

thinkasany reviewed May 7, 2025

View reviewed changes

Comment thread components/time-picker/index.en-US.md Outdated

update

4b9b00d

thinkasany reviewed May 7, 2025

View reviewed changes

Comment thread components/date-picker/generatePicker/generateSinglePicker.tsx Outdated

aojunhao123 added 3 commits May 7, 2025 14:28

update

e50abb6

update

a8eb64b

update

7f67dc7

zombieJ approved these changes May 7, 2025

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label May 7, 2025

zombieJ merged commit 1739167 into ant-design:feature May 7, 2025
40 of 41 checks passed

Uh oh!

Conversation

aojunhao123 commented May 3, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented May 3, 2025

Uh oh!

coderabbitai Bot commented May 3, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53718 Failed ❌

Uh oh!

github-actions Bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant Bot commented May 3, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

thinkasany commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

li-jia-nan commented Sep 14, 2025

Uh oh!

thinkasany commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented May 3, 2025 •

edited

Loading

github-actions Bot commented May 3, 2025 •

edited

Loading

pkg-pr-new Bot commented May 3, 2025 •

edited

Loading

codecov Bot commented May 3, 2025 •

edited

Loading

codecov Bot commented May 3, 2025 •

edited

Loading