fix(Tabs): remove active text shadow by guoyunhe · Pull Request #53617 · ant-design/ant-design

guoyunhe · 2025-04-24T03:51:22Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

Tabs 用 text-shadow 实现了一个伪加粗效果（目的是不改变宽度）：

这种实现有几个问题：

与真实的字体加粗相比，这种加粗比较机械，字形不美观
操作系统的字体微调对 text-shadow 不生效，导致在低分辨率屏幕下会模糊或者缺失细节
无法通过控制阴影大小，实现与真实字体加粗相近的粗细，因为这是由字体文件控制的，不一定是等比例的加粗
苹方等字体已经内置了加粗不加宽的解决方案，未来应该是一种趋势，加粗实现应该交还给字体

此 PR 去掉了加粗效果，仅用颜色区分激活态：

市面上不加粗激活 Tab 的例子：

Google 搜索标签页

讨论过程

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	fix(Tabs): remove active text shadow
🇨🇳 Chinese	fix(Tabs): 移除激活态文字阴影

bolt-new-by-stackblitz · 2025-04-24T03:51:25Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-04-24T03:51:28Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-24T03:51:32Z

👁 Visual Regression Report for PR #53617 Failed ❌

🎯 Target branch: next (fb739d0)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 45 changed

Expected (Branch next)	Actual (Current PR)	Diff
card-component-token.compact.png	card-component-token.compact.png
card-component-token.dark.png	card-component-token.dark.png
card-component-token.default.png	card-component-token.default.png
card-tabs.compact.png	card-tabs.compact.png
card-tabs.default.png	card-tabs.default.png
config-provider-size.compact.png	config-provider-size.compact.png
config-provider-size.default.png	config-provider-size.default.png
splitter-nested-in-tabs.compact.png	splitter-nested-in-tabs.compact.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 45 diffs found in this PR: 🔄 45 changed.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

github-actions · 2025-04-24T03:51:32Z

petercat-assistant · 2025-04-24T03:51:36Z

Walkthrough

This pull request removes the text-shadow effect used for simulating bold text in active tabs. The change aims to address issues with aesthetics, clarity on low-resolution screens, and the inability to mimic true boldness. The active state is now distinguished by color alone.

Changes

File	Summary
components/tabs/style/index.ts	Removed `tabsActiveTextShadow` property and its usage in active tab styles.

petercat-assistant · 2025-04-24T03:51:39Z

        color: itemSelectedColor,
-        textShadow: token.tabsActiveTextShadow,
      },



The removal of textShadow: token.tabsActiveTextShadow is a style change aimed at improving aesthetics and clarity. Ensure that this change does not affect any functionality related to tab activation.

pkg-pr-new · 2025-04-24T03:55:02Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53617

commit: 2cdd421

codecov · 2025-04-24T03:55:37Z

Bundle Report

Changes will decrease total bundle size by 162 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.75MB	-162 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	-81 bytes	2.06MB	-0.0%
`antd.min.js`	-81 bytes	1.69MB	-0.0%

codecov · 2025-04-24T04:11:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d7369a3) to head (2cdd421).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          783       783           
  Lines        14207     14207           
  Branches      3735      3735           
=========================================
  Hits         14207     14207

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fix(Tabs): remove active text shadow

4d904d7

petercat-assistant Bot reviewed Apr 24, 2025

View reviewed changes

Merge branch 'next' into next-tab-active

2cdd421

zombieJ approved these changes Apr 24, 2025

View reviewed changes

zombieJ merged commit ec1d94c into ant-design:next Apr 24, 2025
39 checks passed

Uh oh!

Conversation

guoyunhe commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Apr 24, 2025

Uh oh!

coderabbitai Bot commented Apr 24, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented Apr 24, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53617 Failed ❌

Uh oh!

github-actions Bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant Bot commented Apr 24, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant Bot Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

guoyunhe commented Apr 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Apr 24, 2025 •

edited by zombieJ

Loading

github-actions Bot commented Apr 24, 2025 •

edited

Loading

pkg-pr-new Bot commented Apr 24, 2025 •

edited

Loading

codecov Bot commented Apr 24, 2025 •

edited

Loading

codecov Bot commented Apr 24, 2025 •

edited

Loading