feat: Add popupRender API for custom submenu popup rendering by Zyf665 · Pull Request #53566 · ant-design/ant-design

Zyf665 · 2025-04-20T07:30:14Z

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Add popupRender API to Menu and SubMenu components to support custom submenu popup rendering.
🇨🇳 Chinese

bolt-new-by-stackblitz · 2025-04-20T07:30:17Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-04-20T07:30:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-20T07:30:25Z

👁 Visual Regression Report for PR #53566 Failed ❌

🎯 Target branch: next (7baf185)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🆕 3 added

Expected (Branch next)	Actual (Current PR)	Diff
	menu-custom-popup-render.compact.png	🆕🆕🆕 Added 🆕🆕🆕
	menu-custom-popup-render.dark.png	🆕🆕🆕 Added 🆕🆕🆕
	menu-custom-popup-render.default.png	🆕🆕🆕 Added 🆕🆕🆕

Important

There are 3 diffs found in this PR: 🆕 3 added.
Please check all items:

Visual diff is acceptable

github-actions · 2025-04-20T07:30:27Z

pkg-pr-new · 2025-04-20T07:33:46Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53566

commit: 11fc9fc

codecov · 2025-04-20T07:34:02Z

Bundle Report

Changes will increase total bundle size by 7.76MB (207.05%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
antd.min-array-push	11.51MB	7.76MB (207.05%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js` (New)	6.06MB	6.06MB	100.0% 🚀
`antd.js` (New)	5.45MB	5.45MB	100.0% 🚀
~~`antd-with-locales.min.js`~~ (Deleted)	-2.06MB	0 bytes	-100.0% 🗑️
~~`antd.min.js`~~ (Deleted)	-1.69MB	0 bytes	-100.0% 🗑️

codecov · 2025-04-21T13:37:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf83295) to head (11fc9fc).
Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53566   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          787       788    +1     
  Lines        14291     14304   +13     
  Branches      3780      3786    +6     
=========================================
+ Hits         14291     14304   +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zombieJ · 2025-04-25T03:00:26Z

+
+const styles = {
+  navigationPopup: {
+    padding: '24px',


都不需要 px，直接数字类型

zombieJ · 2025-04-25T03:00:49Z

+};
+
+const addHoverEffect = (e: MouseEvent<HTMLDivElement>) => {
+  e.currentTarget.style.background = 'rgba(0, 0, 0, 0.02)';


用 css 实现，不能直接操作 dom 节点。可以参考其他用 antd-styled 的例子

zombieJ · 2025-04-30T15:47:39Z

+
+const styles = {
+  navigationPopup: {
+    padding: 12,


用 antd-styled，或者如果不用 antd 的 token 也可以考虑用 tailwind

feat: Add popupRender API for custom submenu popup rendering

ed84819

Zyf665 and others added 3 commits April 21, 2025 21:14

Merge branch 'ant-design:next' into next

e9c4ae1

更新快照

d8b5573

Merge branch 'next' of https://github.com/Zyf665/ant-design into next

9b52ca1

zombieJ reviewed Apr 25, 2025

View reviewed changes

Comment thread components/menu/demo/custom-popup-render.tsx Outdated

zombieJ reviewed Apr 25, 2025

View reviewed changes

样式调整,规范调整

3f08946

thinkasany reviewed Apr 27, 2025

View reviewed changes

Comment thread package.json Outdated

Zyf665 and others added 3 commits April 28, 2025 13:51

resolve conflicts

b5ee219

更新快照

11126cf

Merge branch 'next' into next

6c5b22a

zombieJ reviewed Apr 30, 2025

View reviewed changes

Zyf665 and others added 3 commits May 7, 2025 21:21

使用antd-style重写demo

be9cafa

Merge branch 'next' of https://github.com/Zyf665/ant-design into next

c96f52a

Merge branch 'next' into next

95f96cc

zombieJ self-assigned this May 16, 2025

zombieJ added 3 commits May 16, 2025 16:02

Merge remote-tracking branch 'origin/next' into tmp-next

a614d05

test: update snapshot

3dec6f3

chore: clean up

11fc9fc

zombieJ approved these changes May 16, 2025

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label May 16, 2025

zombieJ merged commit 454b33b into ant-design:next May 16, 2025
38 of 39 checks passed

Uh oh!

Conversation

Zyf665 commented Apr 20, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Apr 20, 2025

Uh oh!

coderabbitai Bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented Apr 20, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53566 Failed ❌

Uh oh!

github-actions Bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zombieJ Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

zombieJ Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zombieJ Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Apr 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Apr 20, 2025 •

edited by zombieJ

Loading

github-actions Bot commented Apr 20, 2025 •

edited

Loading

pkg-pr-new Bot commented Apr 20, 2025 •

edited

Loading

codecov Bot commented Apr 20, 2025 •

edited

Loading

codecov Bot commented Apr 21, 2025 •

edited

Loading

zombieJ Apr 25, 2025 •

edited

Loading