feat(auto-complete): popup supports Semantic DOM and retire some api by aojunhao123 · Pull Request #53257 · ant-design/ant-design

aojunhao123 · 2025-03-22T15:58:01Z

🤔 This is a ...

🆕 New feature
🛠 Refactoring

🔗 Related Issues

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	🆕 AutoComplete component adds popup semantic node with support for customizing dropdown menu via classNames.popup, styles.popup, popupRender and onPopupVisibleChange, while deprecating legacy popupClassName, dropdownClassName, dropdownStyle, dropdownRender and onDropdownVisibleChange APIs.
🇨🇳 Chinese	🆕 AutoComplete 组件新增 popup 语义节点，支持通过 classNames.popup、styles.popup、popupRender 和 onPopupVisibleChange 自定义弹出菜单，并废弃旧的 popupClassName、dropdownClassName、dropdownStyle、dropdownRender 和 onDropdownVisibleChange API

bolt-new-by-stackblitz · 2025-03-22T15:58:04Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-03-22T15:58:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-22T15:58:14Z

github-actions · 2025-03-22T15:58:14Z

👁 Visual Regression Report for PR #53257 Passed ✅

🎯 Target branch: feature (fcbe7c9)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

pkg-pr-new · 2025-03-22T16:01:33Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53257

commit: bfa09e4

codecov · 2025-03-22T16:02:47Z

Bundle Report

Changes will decrease total bundle size by 6.27MB (-64.91%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.39MB	-6.27MB (-64.91%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js` (New)	1.85MB	1.85MB	100.0% 🚀
`antd.min.js` (New)	1.54MB	1.54MB	100.0% 🚀
~~`antd-with-locales.js`~~ (Deleted)	-5.08MB	0 bytes	-100.0% 🗑️
~~`antd.js`~~ (Deleted)	-4.58MB	0 bytes	-100.0% 🗑️

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

codecov · 2025-03-22T16:14:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fcbe7c9) to head (bfa09e4).
Report is 1 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #53257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          771       771           
  Lines        13902     13907    +5     
  Branches      3661      3664    +3     
=========================================
+ Hits         13902     13907    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…in favor of `onOpenChange` and update related tests

…mentation

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Jony J <1844749591@qq.com>

socket-security · 2025-04-01T14:14:26Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/rc-cascader@3.33.1 ➜ 3.34.0	environment	`0`	181 kB	zombiej

View full report↗︎

li-jia-nan · 2025-04-02T18:27:51Z

+  const [locale] = useLocale(locales);
+
+  return (
+    <SemanticPreview


这里得加上 componentName

feat(auto-complete): popup supports Semantic DOM and retire some api

565eff9

Merge branch 'feature' into popup-auto-complete

f587365

zombieJ reviewed Mar 24, 2025

View reviewed changes

Comment thread components/auto-complete/AutoComplete.tsx Outdated

aojunhao123 added 2 commits March 24, 2025 14:49

refactor(auto-complete, select): deprecate onDropdownVisibleChange …

4645f77

…in favor of `onOpenChange` and update related tests

Merge branch 'feature' into popup-auto-complete

689de82

zombieJ reviewed Mar 24, 2025

View reviewed changes

Comment thread components/auto-complete/demo/_semantic.tsx Outdated

aojunhao123 added 6 commits March 24, 2025 22:13

Merge branch 'feature' into popup-auto-complete

57211eb

refactor: adjust semantic demo logic

2978bb2

docs: update api description

d20b489

docs: update doc

1d11db7

docs: add space

43d2e32

docs: update

fe28a18

zombieJ reviewed Mar 25, 2025

View reviewed changes

Comment thread components/auto-complete/demo/_semantic.tsx Outdated

aojunhao123 and others added 4 commits March 26, 2025 10:14

Merge branch 'feature' into popup-auto-complete

48a7adb

chore: update semantic demo logic

687ff62

Merge branch 'feature' into popup-auto-complete

06e4207

feat: add CP support

4b5548b

thinkasany reviewed Mar 26, 2025

View reviewed changes

Comment thread components/config-provider/context.ts Outdated

aojunhao123 added 2 commits March 27, 2025 16:45

feat: add CP support for tree-select and update doc

088074c

docs: update Select and TreeSelect common props in configuration docu…

b5c7d65

…mentation

graphite-app Bot reviewed Mar 27, 2025

View reviewed changes

Comment thread components/config-provider/index.zh-CN.md Outdated

Update components/config-provider/index.zh-CN.md

178d920

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Jony J <1844749591@qq.com>

zombieJ reviewed Mar 27, 2025

View reviewed changes

Comment thread .dumi/components/TemplateSemanticPreview.tsx

aojunhao123 and others added 3 commits March 28, 2025 15:08

feat: add root support

44b34dc

Merge branch 'feature' into popup-auto-complete

a8bcc26

Merge branch 'feature' into popup-auto-complete

4ffb5d5

zombieJ reviewed Mar 31, 2025

View reviewed changes

Comment thread components/select/index.tsx

zombieJ reviewed Mar 31, 2025

View reviewed changes

Comment thread components/select/index.zh-CN.md Outdated

aojunhao123 added 3 commits March 31, 2025 11:01

Merge branch 'feature' into popup-auto-complete

9695de9

docs: update doc

7609b51

Merge branch 'feature' into popup-auto-complete

8be0e50

graphite-app Bot reviewed Mar 31, 2025

View reviewed changes

Comment thread components/auto-complete/AutoComplete.tsx

aojunhao123 added 2 commits April 1, 2025 10:40

chore: resolve conflicts

91e1bf8

chore: bump cascader version

bfa09e4

zombieJ approved these changes Apr 2, 2025

View reviewed changes

zombieJ merged commit 3147356 into ant-design:feature Apr 2, 2025
42 checks passed

aojunhao123 deleted the popup-auto-complete branch April 2, 2025 04:09

li-jia-nan reviewed Apr 2, 2025

View reviewed changes

This was referenced May 6, 2025

chore: master merge feature #53738

Merged

docs: changelog 5.25.0 #53740

Merged

achuribooks mentioned this pull request Jul 15, 2025

chore: bump antd from 5.22.2 to 5.26.3 spectrocloud/librarium#7257

Merged

Uh oh!

Conversation

aojunhao123 commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Mar 22, 2025

Uh oh!

coderabbitai Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53257 Passed ✅

Uh oh!

pkg-pr-new Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security Bot commented Apr 1, 2025

Uh oh!

Uh oh!

li-jia-nan Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aojunhao123 commented Mar 22, 2025 •

edited

Loading

coderabbitai Bot commented Mar 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions Bot commented Mar 22, 2025 •

edited

Loading

github-actions Bot commented Mar 22, 2025 •

edited

Loading

pkg-pr-new Bot commented Mar 22, 2025 •

edited

Loading

codecov Bot commented Mar 22, 2025 •

edited

Loading

codecov Bot commented Mar 22, 2025 •

edited

Loading