feat: ConfigProvider support button variant and color by yellowryan · Pull Request #53165 · ant-design/ant-design

yellowryan · 2025-03-14T15:18:29Z

🤔 This is a ...

🔗 Related Issues

Related to #53081

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Added ConfigProvider to support setting the variant and color properties of buttons
🇨🇳 Chinese	新增ConfigProvider支持设置button的variant和color属性

bolt-new-by-stackblitz · 2025-03-14T15:18:33Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-03-14T15:18:42Z

github-actions · 2025-03-14T15:18:43Z

👁 Visual Regression Report for PR #53165 Passed ✅

🎯 Target branch: feature (45fcb4b)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

petercat-assistant · 2025-03-14T15:18:47Z

Walkthrough

This pull request introduces a new feature to the ConfigProvider, allowing it to support setting the variant and color properties of buttons. This enhancement provides more flexibility in button styling by enabling global configuration of these properties.

Changes

Files	Summary
components/button/tests/index.test.tsx	Added tests for ConfigProvider's support of button variant and color properties.
components/button/button.tsx	Modified to utilize ConfigContext for button variant and color configuration.
components/config-provider/context.ts	Extended ButtonConfig type to include variant and color properties.
components/config-provider/index.en-US.md, components/config-provider/index.zh-CN.md	Updated documentation to reflect new button properties in ConfigProvider.

pkg-pr-new · 2025-03-14T15:22:03Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53165

commit: 7eca5fa

codecov · 2025-03-14T15:23:12Z

Bundle Report

Changes will increase total bundle size by 336 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.39MB	336 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	168 bytes	1.85MB	0.01%
`antd.min.js`	168 bytes	1.54MB	0.01%

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.51kB

codecov · 2025-03-14T15:36:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c073d2c) to head (7eca5fa).
Report is 1 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #53165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          771       771           
  Lines        13902     13907    +5     
  Branches      3656      3658    +2     
=========================================
+ Hits         13902     13907    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai · 2025-03-19T11:33:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

docs update Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com>

* feat: ConfigProvider support button variant property * feat: ConfigProvider support button color * docs: update config-provider api docs * test: add test case * Update components/config-provider/index.en-US.md docs update Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com> * Update components/config-provider/index.zh-CN.md docs update Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com> * test: add test case * fix: logic * fix(button): improve button color and variant handling logic --------- Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com> Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Co-authored-by: 二货机器人 <smith3816@gmail.com> Co-authored-by: thinkasany <480968828@qq.com> Co-authored-by: ice <1597834867@qq.com>

petercat-assistant Bot reviewed Mar 14, 2025

View reviewed changes

Comment thread components/button/button.tsx Outdated

coding-ice reviewed Mar 19, 2025

View reviewed changes

Comment thread components/config-provider/index.en-US.md Outdated

Comment thread components/config-provider/index.zh-CN.md Outdated

yellowryan and others added 6 commits March 19, 2025 20:33

feat: ConfigProvider support button variant property

ce47c01

feat: ConfigProvider support button color

72bb437

docs: update config-provider api docs

70c0eed

test: add test case

0b7de51

Update components/config-provider/index.en-US.md

3a6969c

docs update Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com>

Update components/config-provider/index.zh-CN.md

616b5ca

docs update Co-authored-by: ice <49827327+coding-ice@users.noreply.github.com> Signed-off-by: Ryan <55972954+yellowryan@users.noreply.github.com>

yellowryan force-pushed the button-variant-config-provider branch from 598dbf7 to 616b5ca Compare March 19, 2025 12:35

yellowryan requested a review from coding-ice March 19, 2025 12:59

coding-ice reviewed Mar 19, 2025

View reviewed changes

Comment thread components/button/button.tsx Outdated

yellowryan added 2 commits March 22, 2025 04:13

Merge branch 'feature' into button-variant-config-provider

2dc4e78

Merge branch 'feature' into button-variant-config-provider

55c75c8

zombieJ self-assigned this Mar 25, 2025

zombieJ and others added 3 commits March 25, 2025 23:55

test: add test case

0a3fe57

fix: logic

9aca763

Merge branch 'feature' into button-variant-config-provider

4dddc1e

thinkasany previously approved these changes Mar 26, 2025

View reviewed changes

fix(button): improve button color and variant handling logic

7eca5fa

coding-ice dismissed thinkasany’s stale review via 7eca5fa March 26, 2025 02:33

zombieJ approved these changes Mar 26, 2025

View reviewed changes

coding-ice merged commit 419a0dc into ant-design:feature Mar 26, 2025
42 checks passed

This was referenced May 6, 2025

chore: master merge feature #53738

Merged

docs: changelog 5.25.0 #53740

Merged

Uh oh!

Conversation

yellowryan commented Mar 14, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Mar 14, 2025

Uh oh!

github-actions Bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53165 Passed ✅

Uh oh!

petercat-assistant Bot commented Mar 14, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

pkg-pr-new Bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Mar 14, 2025 •

edited

Loading

github-actions Bot commented Mar 14, 2025 •

edited

Loading

pkg-pr-new Bot commented Mar 14, 2025 •

edited

Loading

codecov Bot commented Mar 14, 2025 •

edited

Loading

codecov Bot commented Mar 14, 2025 •

edited

Loading

coderabbitai Bot commented Mar 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)