feat(Tag): custom color support 3 variants by guoyunhe · Pull Request #53097 · ant-design/ant-design

guoyunhe · 2025-03-08T02:19:50Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

Tag 的 color 属性，在提供非预设颜色时，只能以实色填充展示，与内置颜色的外观差异巨大。另外 color="xxx-inverse" 和 borderless={false} 的用法也不够优雅。

此 PR 提供了一个额外的属性，variant: 'outlined' | 'filled' | 'borderless'，以统一内置颜色和自定义颜色的效果，同时提供三种变体。减少 xxx-reverse 预设数量，且不需要 borderless 属性。

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	feat(Tag): custom color support 3 variants
🇨🇳 Chinese	feat(Tag): 自定义颜色支持 3 种变体

bolt-new-by-stackblitz · 2025-03-08T02:19:53Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-03-08T02:20:00Z

👁 Visual Regression Report for PR #53097 Failed ❌

🎯 Target branch: next (d5f0fc1)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 45 changed, 🛑 9 removed

Expected (Branch next)	Actual (Current PR)	Diff
select-custom-tag-render.compact.png	select-custom-tag-render.compact.png
select-custom-tag-render.dark.png	select-custom-tag-render.dark.png
select-custom-tag-render.default.png	select-custom-tag-render.default.png
table-basic.compact.png	table-basic.compact.png
table-basic.dark.png	table-basic.dark.png
table-basic.default.png	table-basic.default.png
table-jsx.compact.png	table-jsx.compact.png
table-jsx.dark.png	table-jsx.dark.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.

Important

There are 54 diffs found in this PR: 🔄 45 changed, 🛑 9 removed.
Please check all items:

Checked all diffs in the full report
Visual diff is acceptable

github-actions · 2025-03-08T02:20:03Z

petercat-assistant · 2025-03-08T02:20:06Z

Walkthrough

This pull request introduces a new feature to the Tag component, allowing custom colors to support two variants: 'outlined' and 'filled'. This change aims to reduce the visual difference between custom and preset colors by providing a consistent appearance.

Changes

File	Summary
components/tag/demo/colorful.tsx	Added examples for 'outlined' and 'filled' variants of custom colors.
components/tag/index.en-US.md, components/tag/index.zh-CN.md	Updated documentation to include the new 'variant' property.
components/tag/index.tsx	Implemented logic to handle 'outlined' and 'filled' variants for custom colors using the FastColor library.

petercat-assistant · 2025-03-08T02:20:09Z

+        tagStyle.background = color;
+      } else {
+        tagStyle.borderColor = color;
+        const hsl = new FastColor(color).toHsl();


Ensure that the FastColor library is thoroughly tested with various color inputs to avoid unexpected behavior, especially with edge cases like very light or very dark colors.

pkg-pr-new · 2025-03-08T02:23:27Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@53097

commit: b4b1063

codecov · 2025-03-08T02:23:32Z

Bundle Report

Changes will increase total bundle size by 7.84MB (199.3%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
antd.min-array-push	11.78MB	7.84MB (199.3%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js` (New)	6.19MB	6.19MB	100.0% 🚀
`antd.js` (New)	5.59MB	5.59MB	100.0% 🚀
~~`antd-with-locales.min.js`~~ (Deleted)	-2.16MB	0 bytes	-100.0% 🗑️
~~`antd.min.js`~~ (Deleted)	-1.78MB	0 bytes	-100.0% 🗑️

Files in antd-with-locales.js:

./components/tag/style/index.ts → Total Size: 5.82kB
./components/config-provider/context.ts → Total Size: 1.51kB

Files in antd.js:

./components/config-provider/context.ts → Total Size: 1.51kB
./components/tag/style/index.ts → Total Size: 5.82kB

codecov · 2025-03-08T03:17:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ffe0cce) to head (b4b1063).
Report is 7 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #53097   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          779       780    +1     
  Lines        14066     14104   +38     
  Branches      3696      3708   +12     
=========================================
+ Hits         14066     14104   +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zombieJ · 2025-03-20T09:44:08Z

 | --- | --- | --- | --- | --- |
 | closeIcon | Custom close icon. 5.7.0: close button will be hidden when setting to `null` or `false` | ReactNode | false | 4.4.0 |
 | color | Color of the Tag | string | - |  |
+| variant | Variant of the tag | `'borderless' \| 'filled' \| 'outlined'` | `'borderless'` | 6.0.0 |


filled 的 default 非常看不清：

已修复，和 Button 的 default+filled 颜色保持一致

coderabbitai · 2025-03-22T01:27:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

li-jia-nan · 2025-03-25T12:38:36Z

某些时候 icon 没有垂直对齐（不过看起来是分辨率的精度问题，恢复到 100% 就没问题）：

li-jia-nan · 2025-03-25T12:38:54Z

这个 default 的颜色在 dark 模式下看起来不太对👇

thinkasany · 2025-03-25T12:43:24Z

+    // ====================== Styles ======================
+    const tagStyle = React.useMemo(() => {
+      let nextTagStyle: React.CSSProperties = {
+        ...contextStyles.root,


顺手用新的 semantic hooks 合并优化一下呗～

petercat-assistant Bot reviewed Mar 8, 2025

View reviewed changes

guoyunhe force-pushed the next-tag-variant branch from dd3fd4b to 80d6753 Compare March 8, 2025 02:58

guoyunhe force-pushed the next-tag-variant branch from 80d6753 to 4676cd2 Compare March 8, 2025 03:18

guoyunhe changed the title ~~feat(Tag): custom color support two variants~~ feat(Tag): custom color support 3 variants Mar 8, 2025

guoyunhe force-pushed the next-tag-variant branch 5 times, most recently from 0dbf4ef to 7d131ef Compare March 9, 2025 01:58

zombieJ reviewed Mar 11, 2025

View reviewed changes

Comment thread components/tag/demo/colorful.tsx Outdated

zombieJ reviewed Mar 11, 2025

View reviewed changes

Comment thread components/tag/index.tsx Outdated

guoyunhe force-pushed the next-tag-variant branch from 7d131ef to e60d6e4 Compare March 11, 2025 10:38

zombieJ reviewed Mar 20, 2025

View reviewed changes

guoyunhe force-pushed the next-tag-variant branch from e60d6e4 to a56e8ee Compare March 22, 2025 01:27

feat(Tag): custom color support 3 variants

7c3bafd

guoyunhe force-pushed the next-tag-variant branch from a56e8ee to 7c3bafd Compare March 22, 2025 01:59

zombieJ self-assigned this Mar 24, 2025

zombieJ added 5 commits March 24, 2025 19:42

Merge remote-tracking branch 'origin/next' into pr/guoyunhe/53097

ba91e1c

chore: merge next

bf41d94

chore: use hooks

611749f

chore: update size limit

644ffac

test: coverage

f375838

test: coverage

da78e83

li-jia-nan previously approved these changes Mar 25, 2025

View reviewed changes

thinkasany reviewed Mar 25, 2025

View reviewed changes

zombieJ added 3 commits March 25, 2025 21:01

fix: variant name

01d0ba7

fix: solid default color

cd53e70

test: update snapshot

78c2f01

zombieJ dismissed li-jia-nan’s stale review via 78c2f01 March 25, 2025 13:22

zombieJ added 6 commits March 25, 2025 21:37

test: update snapshot

0007691

test: update snapshot

f489499

test: update snapshot

4063ec9

test: update snapshot

de76926

demo: cov

ae30aa9

test: coverage

b4b1063

li-jia-nan approved these changes Mar 25, 2025

View reviewed changes

zombieJ merged commit b47db12 into ant-design:next Mar 25, 2025
40 checks passed

Uh oh!

Conversation

guoyunhe commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz Bot commented Mar 8, 2025

Uh oh!

github-actions Bot commented Mar 8, 2025 • edited by zombieJ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #53097 Failed ❌

Uh oh!

github-actions Bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petercat-assistant Bot commented Mar 8, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant Bot Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new Bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zombieJ Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

guoyunhe Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

li-jia-nan commented Mar 25, 2025

Uh oh!

li-jia-nan commented Mar 25, 2025

Uh oh!

thinkasany Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guoyunhe commented Mar 8, 2025 •

edited

Loading

github-actions Bot commented Mar 8, 2025 •

edited by zombieJ

Loading

github-actions Bot commented Mar 8, 2025 •

edited

Loading

pkg-pr-new Bot commented Mar 8, 2025 •

edited

Loading

codecov Bot commented Mar 8, 2025 •

edited

Loading

codecov Bot commented Mar 8, 2025 •

edited

Loading

coderabbitai Bot commented Mar 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)