Skip to content

fix: fix incorrect icon orientation in RTL mode#52896

Merged
afc163 merged 1 commit intomasterfrom
separator-fix
Feb 20, 2025
Merged

fix: fix incorrect icon orientation in RTL mode#52896
afc163 merged 1 commit intomasterfrom
separator-fix

Conversation

@li-jia-nan
Copy link
Copy Markdown
Member

@li-jia-nan li-jia-nan commented Feb 19, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English 修复了 RTL 模式下 icon 上下颠倒的问题
🇨🇳 Chinese 修复了 RTL 模式下 icon 上下颠倒的问题

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Feb 19, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2025 •
edited
Loading

👁 Visual Regression Report for PR #52896 Passed ✅

🎯 Target branch: master (0c74505)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2025 •
edited
Loading

Preview is ready

@petercat-assistant
Copy link
Copy Markdown

petercat-assistant Bot commented Feb 19, 2025

Walkthrough

This pull request addresses a bug fix related to the incorrect orientation of icons in RTL (Right-to-Left) mode. The change involves updating the CSS transformation property to correct the icon orientation.

Changes

File Summary
components/date-picker/style/index.ts Changed the CSS transform property from rotate(180deg) to scale(-1, 1) for RTL mode to fix icon orientation.

petercat-assistant[bot]
petercat-assistant Bot reviewed Feb 19, 2025
View reviewed changes
Comment thread components/date-picker/style/index.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2025

size-limit report 📦

Path Size
dist/antd.min.js 447.8 KB (+9 B 🔺)
dist/antd-with-locales.min.js 532.95 KB (-1 B 🔽)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 19, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52896

commit: 6cb0711

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 4 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB -4 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js -2 bytes 1.84MB -0.0%
antd.min.js -2 bytes 1.54MB -0.0%

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Feb 19, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6cb0711
Status: ✅  Deploy successful!
Preview URL: https://fd52f481.ant-design.pages.dev
Branch Preview URL: https://separator-fix.ant-design.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0c74505) to head (6cb0711).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #52896   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          768       768           
  Lines        13849     13849           
  Branches      3631      3631           
=========================================
  Hits         13849     13849

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Copy Markdown
Member

afc163 commented Feb 20, 2025

啥问题？

@li-jia-nan
Copy link
Copy Markdown
Member Author

li-jia-nan commented Feb 20, 2025

啥问题？

这个箭头应该朝上

image

RTL 模式里上下左右都翻转了：

image

@afc163 afc163 merged commit 2880c35 into master Feb 20, 2025
@afc163 afc163 deleted the separator-fix branch February 20, 2025 02:39
@PeachScript PeachScript mentioned this pull request Feb 24, 2025
Merged
16 tasks
renny-ren pushed a commit to renny-ren/ant-design that referenced this pull request Apr 14, 2025
@li-jia-nan @renny-ren
fix: fix incorrect icon orientation in rtl mode (ant-design#52896)
40ad403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163 afc163 afc163 approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@li-jia-nan @afc163