fix(Watermark): remove 'hidden' when append watermark, prevent hide …#52891
fix(Watermark): remove 'hidden' when append watermark, prevent hide …#52891afc163 merged 2 commits intoant-design:masterfrom
Conversation
…watermark by editing DOM attributes
|
|
|
|
👁 Visual Regression Report for PR #52891 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
WalkthroughThis pull request modifies the watermark component to remove the 'hidden' attribute when appending the watermark element. This change is intended to prevent the watermark from being hidden by editing DOM attributes, enhancing the robustness of the watermark feature. Changes
|
| ); | ||
| // Prevents using the browser `Hide Element` to hide watermarks | ||
| watermarkEle.removeAttribute('class'); | ||
| watermarkEle.removeAttribute('hidden') |
There was a problem hiding this comment.
Ensure that removing the 'hidden' attribute does not inadvertently expose any sensitive information or affect other functionalities that rely on this attribute.
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52891 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 768 768
Lines 13844 13848 +4
Branches 3629 3629
=========================================
+ Hits 13844 13848 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: afc163 <afc163@gmail.com>
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
…ant-design#52891) * feat(Watermark): remove 'hidden' when append watermark, prevent hide watermark by editing DOM attributes * Update components/watermark/useWatermark.ts Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: afc163 <afc163@gmail.com>
…watermark by editing DOM attributes
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log