fix: dropdown submenu arrow wrong direction in rtl#52885
Merged
li-jia-nan merged 6 commits intoant-design:masterfrom Feb 19, 2025
Merged
fix: dropdown submenu arrow wrong direction in rtl#52885li-jia-nan merged 6 commits intoant-design:masterfrom
li-jia-nan merged 6 commits intoant-design:masterfrom
Conversation
|
|
Contributor
👁 Visual Regression Report for PR #52885 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
Contributor
|
|
WalkthroughThis pull request addresses a bug fix for the dropdown component in RTL (Right-to-Left) mode. It corrects the direction of the submenu arrow, ensuring it points in the correct direction when RTL is enabled. Changes
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 144 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52885 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 768 768
Lines 13847 13849 +2
Branches 3629 3631 +2
=========================================
+ Hits 13847 13849 +2 ☔ View full report in Codecov by Sentry. |
thinkasany
reviewed
Feb 19, 2025
li-jia-nan
reviewed
Feb 19, 2025
li-jia-nan
previously approved these changes
Feb 19, 2025
li-jia-nan
reviewed
Feb 19, 2025
Signed-off-by: lijianan <574980606@qq.com>
li-jia-nan
approved these changes
Feb 19, 2025
16 tasks
renny-ren
pushed a commit
to renny-ren/ant-design
that referenced
this pull request
Apr 14, 2025
* fix: dropdown submenu arrow wrong direction in rtl * test: dropdown arrow direction in rtl mode * Update components/dropdown/dropdown.tsx Signed-off-by: lijianan <574980606@qq.com> --------- Signed-off-by: lijianan <574980606@qq.com> Co-authored-by: thinkasany <480968828@qq.com> Co-authored-by: lijianan <574980606@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
related to #52882
💡 Background and Solution
📝 Change Log