Skip to content

refactor: use breakpoint by Copilot AI#52870

Merged
zombieJ merged 7 commits intomasterfrom
refactor-grid
Feb 18, 2025
Merged

refactor: use breakpoint by Copilot AI#52870
zombieJ merged 7 commits intomasterfrom
refactor-grid

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Feb 18, 2025 •
edited
Loading

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

Masonry 里也要用到类似逻辑，提前抽一下。

📝 Change Log

Language Changelog
🇺🇸 English Refactor Gird internal useBreakpoint logic to be same as other component, this will not affect usage.
🇨🇳 Chinese 【需要在日志里写出来，以防把人搞坏了】 重构 Gird 内部响应式逻辑以复用其他组件类似的逻辑，该更新不会于使用上有所变化。

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Feb 18, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited by zombieJ
Loading

👁 Visual Regression Report for PR #52870 Failed ❌

🎯 Target branch: master (a8f116f)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 3 changed

Expected (Branch master) Actual (Current PR) Diff
input-number-debug-token.compact.png input-number-debug-token.compact.png input-number-debug-token.compact.css-var.png input-number-debug-token.compact.css-var.png
input-number-debug-token.dark.png input-number-debug-token.dark.png input-number-debug-token.dark.css-var.png input-number-debug-token.dark.css-var.png
input-number-debug-token.default.png input-number-debug-token.default.png input-number-debug-token.default.css-var.png input-number-debug-token.default.css-var.png

Important

There are 3 diffs found in this PR: 🔄 3 changed.
Please check all items:

  • Visual diff is acceptable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited
Loading

Preview is ready

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/antd.min.js 447.8 KB (+204 B 🔺)
dist/antd-with-locales.min.js 532.92 KB (-346 B 🔽)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 18, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52870

commit: bd710b5

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 6.26MB (-64.93%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB -6.26MB (-64.93%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js (New) 1.84MB 1.84MB 100.0% 🚀
antd.min.js (New) 1.54MB 1.54MB 100.0% 🚀
antd-with-locales.js (Deleted) -5.07MB 0 bytes -100.0% 🗑️
antd.js (Deleted) -4.57MB 0 bytes -100.0% 🗑️

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Feb 18, 2025 •
edited
Loading

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd710b5
Status: ✅  Deploy successful!
Preview URL: https://61ddd35d.ant-design.pages.dev
Branch Preview URL: https://refactor-grid.ant-design.pages.dev

View logs

@zombieJ zombieJ changed the title refactor: use breakpoint refactor: use breakpoint by Copilot AI Feb 18, 2025
@zombieJ zombieJ marked this pull request as ready for review February 18, 2025 10:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (080f780) to head (bd710b5).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #52870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          767       768    +1     
  Lines        13846     13840    -6     
  Branches      3628      3628           
=========================================
- Hits         13846     13840    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit dd20460 into master Feb 18, 2025
@zombieJ zombieJ deleted the refactor-grid branch February 18, 2025 11:49
@PeachScript PeachScript mentioned this pull request Feb 24, 2025
Merged
16 tasks
renny-ren pushed a commit to renny-ren/ant-design that referenced this pull request Apr 14, 2025
@zombieJ @renny-ren
refactor: use breakpoint by Copilot AI (ant-design#52870)
3bff887 
* refactor: use breakpoint

* refactor: add hooks

* chore: clean up

* chore: fix logic

* chore: fix logic

* chore: fix ts

* chore: fix ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadCcc MadCcc MadCcc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zombieJ @MadCcc