Skip to content

perf[menu]: Optimize expandIcon rerender #52863

Merged
wanpan11 merged 1 commit intoant-design:masterfrom
wanpan11:rc-menu
Feb 18, 2025
Merged

perf[menu]: Optimize expandIcon rerender #52863
wanpan11 merged 1 commit intoant-design:masterfrom
wanpan11:rc-menu

Conversation

@wanpan11
Copy link
Copy Markdown
Member

@wanpan11 wanpan11 commented Feb 18, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English perf: Optimize expandIcon rerender
🇨🇳 Chinese 优化 expandIconNode 传入函数时重复调用

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz Bot commented Feb 18, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited
Loading

Preview is ready

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025 •
edited
Loading

👁 Visual Regression Report for PR #52863 Passed ✅

🎯 Target branch: master (080f780)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@petercat-assistant
Copy link
Copy Markdown

petercat-assistant Bot commented Feb 18, 2025

Walkthrough

This pull request updates the rc-menu package from version ~9.16.0 to ~9.16.1 in the package.json file. The update is aimed at optimizing the expandIcon rerender process, as referenced in related issues and pull requests.

Changes

Files Summary
package.json Updated rc-menu dependency from ~9.16.0 to ~9.16.1.

petercat-assistant[bot]
petercat-assistant Bot reviewed Feb 18, 2025
View reviewed changes
Comment thread package.json
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 18, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/react-sticky-box@2.0.5

View full report↗︎

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 18, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@52863

commit: 5256393

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 376 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB 376 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 188 bytes 1.84MB 0.01%
antd.min.js 188 bytes 1.54MB 0.01%

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (080f780) to head (5256393).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #52863   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          767       767           
  Lines        13846     13846           
  Branches      3628      3628           
=========================================
  Hits         13846     13846

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanpan11 wanpan11 changed the title chore: update rc-menu perf[menu]: Optimize expandIcon rerender Feb 18, 2025
@wanpan11 wanpan11 merged commit e7b0a9c into ant-design:master Feb 18, 2025
@PeachScript PeachScript mentioned this pull request Feb 24, 2025
Merged
16 tasks
renny-ren pushed a commit to renny-ren/ant-design that referenced this pull request Apr 14, 2025
@wanpan11 @renny-ren
perf[menu]: Optimize expandIcon rerender (ant-design#52863)
3a92027
@wanpan11 wanpan11 deleted the rc-menu branch November 24, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zombieJ zombieJ zombieJ approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Menu自定义expandIcon刷新异常

2 participants

@wanpan11 @zombieJ