Conversation
|
|
|
|
👁 Visual Regression Report for PR #52812 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 12 diffs found in this PR: 🔄
|
WalkthroughThis pull request addresses a bug fix related to the Button component in the Ant Design library. The issue was that the Button with Changes
|
| primary: ['primary', 'solid'], | ||
| dashed: ['default', 'dashed'], | ||
| link: ['primary', 'link'], | ||
| link: ['info', 'link'], |
There was a problem hiding this comment.
The change from primary to info for the link variant ensures that the correct color palette is used, addressing the bug where link was incorrectly using primary colors.
| [`${componentCls}-color-default`]: genDefaultButtonStyle(token), | ||
| [`${componentCls}-color-primary`]: genPrimaryButtonStyle(token), | ||
| [`${componentCls}-color-dangerous`]: genDangerousStyle(token), | ||
| [`${componentCls}-color-info`]: genInfoStyle(token), |
There was a problem hiding this comment.
The addition of genInfoStyle for info color provides a comprehensive style set for the new info color type, ensuring consistent styling across different button variants.
Deploying ant-design with
|
| Latest commit: |
4b8dfa2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3622dde.ant-design.pages.dev |
| Branch Preview URL: | https://fix-preset.ant-design.pages.dev |
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 1.13kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
|
尴尬，还有个 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52812 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 767 767
Lines 13845 13846 +1
Branches 3628 3628
=========================================
+ Hits 13845 13846 +1 ☔ View full report in Codecov by Sentry. |
* fix: Button style of preset * chore: add info of fix * docs: update demo * chore: fix lint * test: update snapshot * fix: color of link * test: update snapshot * test: update snapshot
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
fix #52468
💡 Background and Solution
看了一下是因为
color缺少info类型，所以导致link变体取用的是primary组合，导致了primary为了兼容用的info色板。在 style 里添加一个info样式集合来解决这个问题。📝 Change Log
colorto beprimaryandvariantto betextorlinkwill not use correct color.color为primary并且variant为text或link时，没有取用正确的色板的问题。