fix: change logging info to error in quarto build#655
Merged
Revathyvenugopal162 merged 2 commits intomainfrom Mar 25, 2025
Merged
fix: change logging info to error in quarto build#655Revathyvenugopal162 merged 2 commits intomainfrom
Revathyvenugopal162 merged 2 commits intomainfrom
Conversation
RobPasMue
approved these changes
Mar 25, 2025
RobPasMue
requested changes
Mar 25, 2025
Comment on lines
421
to
+430
| def run_quarto_command(command, cwd): | ||
| """Run quarto command and logs its output.""" | ||
| """Run quarto command and logs its output. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| command : list | ||
| List of command arguments. | ||
| cwd : str | ||
| Current working directory. | ||
| """ |
Member
There was a problem hiding this comment.
If you know the type hints, why not adding them to the method signature?
Member
There was a problem hiding this comment.
My bad - shouldn't have approved that quickly 😄
Contributor
Author
There was a problem hiding this comment.
no problem, i will add that in my coming PR, which is also related to some code refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #650 #649