fix: skip_list with sub-rules no longer skips entire rule#4955
Merged
ssbarnea merged 1 commit intoansible:mainfrom Feb 10, 2026
Merged
fix: skip_list with sub-rules no longer skips entire rule#4955ssbarnea merged 1 commit intoansible:mainfrom
ssbarnea merged 1 commit intoansible:mainfrom
Conversation
4b2f448 to
ca42d3e
Compare
ca42d3e to
72c025f
Compare
ssbarnea
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Adding a sub-rule like
yaml[trailing-spaces]toskip_listwas skipping all yaml checks instead of just that one. This was a regression from PR #4892 where the skip filtering got lost during the tags refactor. The rule now runs and only the specific sub-rule matches get filtered out.Fixes #4952.
Fixes #4040.