Skip to content

fix: no-free-form transform parsing#4942

Merged
ssbarnea merged 7 commits intoansible:mainfrom
Edition-X:issue-4862-fix-no-free-form
Feb 25, 2026
Merged

fix: no-free-form transform parsing#4942
ssbarnea merged 7 commits intoansible:mainfrom
Edition-X:issue-4862-fix-no-free-form

Conversation

@Edition-X
Copy link
Copy Markdown
Contributor

@Edition-X Edition-X commented Jan 29, 2026

Summary

  • Parse no-free-form args with split_args while preserving Jinja with spaces.
  • Fall back to cmd when split_args hits unbalanced quotes to avoid corruption.
  • Keep raw executable parsing aligned with split_args.

Issue Reference

Fixes #4862

Testing

  • python -m mypy src/ansiblelint/rules/no_free_form.py
  • python -m pytest src/ansiblelint/rules/no_free_form.py
  • python -m pytest test/test_transformer.py -k no_free_form_transform

@Edition-X Edition-X requested a review from a team as a code owner January 29, 2026 13:34
@Edition-X Edition-X marked this pull request as draft January 29, 2026 13:36
@Edition-X Edition-X changed the title Fix no-free-form transform handling for Jinja/quotes fix: no-free-form transform parsing Jan 29, 2026
@Edition-X Edition-X force-pushed the issue-4862-fix-no-free-form branch from e17212d to 441259c Compare January 29, 2026 13:54
@github-actions github-actions Bot added the fix label Jan 29, 2026
@github-actions github-actions Bot added fix and removed fix labels Jan 29, 2026
@github-actions github-actions Bot added fix and removed fix labels Jan 29, 2026
@Edition-X Edition-X marked this pull request as ready for review January 29, 2026 14:38
@github-actions github-actions Bot added fix and removed fix labels Jan 30, 2026
@ssbarnea ssbarnea enabled auto-merge (squash) February 25, 2026 14:48
@github-actions github-actions Bot added fix and removed fix labels Feb 25, 2026
@ssbarnea ssbarnea disabled auto-merge February 25, 2026 15:09
@ssbarnea ssbarnea merged commit 7c31308 into ansible:main Feb 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

--fix breaks no-free-form rule

2 participants