build: update compileSdkVersion and targetSdk to 36#427
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| internal fun Project.configureAndroid(): Unit = baseExtension().run { | ||
| compileSdkVersion(34) | ||
| compileSdkVersion(36) | ||
| defaultConfig { | ||
| minSdk = 21 | ||
| targetSdk = 34 | ||
| targetSdk = 36 |
There was a problem hiding this comment.
Install Android 36 SDK for CI builds
Raising compileSdkVersion/targetSdk to 36 means Gradle now requires the android-36 platform, but the Android CI pipeline still runs .github/actions/android/action.yml (lines 7‑15) which only sets up JDK/Gradle and never installs Android SDK platforms, so GitHub runners on ubuntu-latest will error Failed to find target with hash string 'android-36' unless that platform happens to be preinstalled. Please add sdkmanager setup or otherwise provision API 36 in CI before this bump lands.
Useful? React with 👍 / 👎.
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.
Before opening a pull request, please ensure you've done the following:
developand targetsdevelop(where applicable)Description
Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the Apache License 2.0.