Skip to content

fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option#30631

Merged
crisbeto merged 1 commit intoangular:mainfrom
mistrykaran91:fix/automcomplete-overlay-backdrop
Mar 18, 2025
Merged

fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option#30631
crisbeto merged 1 commit intoangular:mainfrom
mistrykaran91:fix/automcomplete-overlay-backdrop

Conversation

@mistrykaran91
Copy link
Copy Markdown
Contributor

@mistrykaran91 mistrykaran91 commented Mar 14, 2025 •
edited
Loading

Currently when we open the panel, backdrop is not allowed and is not inline with mat-select, mat-menu, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes #30457

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 14, 2025 13:08
@mistrykaran91 mistrykaran91 requested review from andrewseguin and crisbeto and removed request for a team March 14, 2025 13:08
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch 3 times, most recently from d89d3ce to f1b5dc5 Compare March 15, 2025 11:30
@crisbeto crisbeto removed the request for review from andrewseguin March 18, 2025 10:20
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Mar 18, 2025
crisbeto
crisbeto requested changes Mar 18, 2025
View reviewed changes
@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Mar 18, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch from 31db0f1 to 2cea4f0 Compare March 18, 2025 11:06
@mistrykaran91 mistrykaran91 requested a review from crisbeto March 18, 2025 11:18
@mistrykaran91 mistrykaran91 changed the title fix(material/autocomplete): allow overlay backdrop when opened fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option Mar 18, 2025
@mistrykaran91
Copy link
Copy Markdown
Contributor Author

mistrykaran91 commented Mar 18, 2025 •
edited
Loading

@crisbeto : Seems action:merge label was removed and not added after the later approval or it will be added later ?

@crisbeto
Copy link
Copy Markdown
Member

crisbeto commented Mar 18, 2025

I'll add it before merging the change in.

@angular-robot angular-robot bot requested a review from crisbeto March 18, 2025 13:10
@mistrykaran91
fix(material/autocomplete): allow overlay backdrop by setting hasBack…
284976e 
…drop option

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes angular#30457
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch from 8b6b28e to 284976e Compare March 18, 2025 13:11
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 18, 2025
@crisbeto crisbeto merged commit 097f49d into angular:main Mar 18, 2025
20 of 22 checks passed
@bumsimausi
Copy link
Copy Markdown

bumsimausi commented Mar 21, 2025

I didn't verify this, but I am currently experiencing issues as described in #26484 and seem to be resolved when the backdrop is added.

I believe this would also fix #26484 and #30416?

As I've seen this is not added to a 19.x.x but to https://github.com/angular/components/releases/tag/20.0.0-next.2

Would it be possible to pick this also into a 19.x.x release?

@bumsimausi
Copy link
Copy Markdown

bumsimausi commented Mar 21, 2025

I didn't verify this, but I am currently experiencing issues as described in #26484 and seem to be resolved when the backdrop is added.

I believe this would also fix #26484 and #30416?

As I've seen this is not added to a 19.x.x but to https://github.com/angular/components/releases/tag/20.0.0-next.2

Would it be possible to pick this also into a 19.x.x release?

@crisbeto maybe you can help me with that?

crisbeto pushed a commit to crisbeto/material2 that referenced this pull request Mar 26, 2025
@mistrykaran91 @crisbeto
fix(material/autocomplete): allow overlay backdrop by setting hasBack…
e23bbdf 
…drop option (angular#30631)

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes angular#30457
@crisbeto crisbeto mentioned this pull request Mar 26, 2025
Merged
@crisbeto
Copy link
Copy Markdown
Member

crisbeto commented Mar 26, 2025

Will be cherry-picked by #30715.

crisbeto added a commit that referenced this pull request Mar 26, 2025
@crisbeto @DavidACCarvalho @mistrykaran91
Cherry pick fixes (#30715)
6d95685 
* fix(material/select): close panel on detach output event (#30634)

* fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option (#30631)

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes #30457

---------

Co-authored-by: DavidACCarvalho <85346154+DavidACCarvalho@users.noreply.github.com>
Co-authored-by: Karan Mistry <karan.mistry@siemens.com>
@mistrykaran91 mistrykaran91 mentioned this pull request Apr 8, 2025
Open
1 task
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 26, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/autocomplete target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(mat-autocomplete): doesn't allow to have an overlay backdrop

3 participants

@mistrykaran91 @crisbeto @bumsimausi