fix(material/slider): handle null values in slider input#30621
Merged
wagnermaciel merged 1 commit intoangular:mainfrom Mar 17, 2025
Merged
Conversation
25d2edf to
77aabff
Compare
kenyerman
suggested changes
Mar 12, 2025
kenyerman
left a comment
There was a problem hiding this comment.
thank you for working on this! ❤️
i've found some falsyness checks that can be improved, please review them and correct me if i'm wrong.
4cc752d to
4c1afd6
Compare
166eaee to
87cbe59
Compare
The slider values behaved inconsistently when we reset the formGroup. This MR will resolve that issue by setting `value` to default value when its `null` Fixes angular#30614
87cbe59 to
0a16cf5
Compare
wagnermaciel
approved these changes
Mar 17, 2025
mistrykaran91
added a commit
to mistrykaran91/components
that referenced
this pull request
Apr 11, 2025
…sses if mat-label is added and removed dynamically Currently, when `mat-Label` is added dynamically initially its not visible in DOM, this fix will added/remove classes for the same. Fixes angular#30621
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slider values behaved inconsistently when we reset the formGroup. This MR will resolve that issue by setting
valueto default value when itsnullFixes #30614