feat(material/card): support filled variant#29868
Conversation
|
Caretaker note: will need to add internal equivalents for the newly defined tokens |
|
This needs rebase, @andrewseguin has been making some changes to how the tokens are organized |
ERROR: D:/open-source/components/BUILD.bazel:16:22: Extracting npm package yargs-parser@21.1.1 [for tool] failed: (Exit 1): tar.exe failed: error executing command (from target //:.aspect_rules_js/node_modules/yargs-parser@21.1.1/pkg) external\bsd_tar_windows_amd64\tar.exe --extract --no-same-owner --no-same-permissions --strip-components 1 --file external/npm2__yargs-parser__21.1.1/package.tgz --directory ... (remaining 1 argument skipped)
tar.exe: Error opening archive: Can't initialize filter; unable to run program "gzip -d"
Target //src/dev-app:devserver failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.286s, Critical Path: 0.21s
INFO: 14 processes: 14 internal.
FAILED: Build did NOT complete successfullyI seem to be running into these issues when running dev-app locally. I will set up a VMware tonight to check changes throughly just in case I didn't miss out something in rebase. edit: I did also try to install package via choco but still seem to be having issue as referenced here edit again: I missed alot of things.. |
af0d0f8 to
03848b4
Compare
a9fd590 to
b4c330e
Compare
this commit add `filled` variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cards fixes angular#29840
update the example to contain `elevated`, `outlined` & `filled` variants
|
Deployed dev-app for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-dev-iorxya0z.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-docs-tplx6v1g.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |




feat(material/card): support filled variant
this commit add
filledvariant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cardsfixes #29840
docs(material/card): add each appearance example
update the example to contain
elevated,outlined&filledvariantsI tried to have a swing at this and it might be not perfect.