fix(core): sanitize sensitive attributes on SVG script elements#66318
Merged
kirjs merged 2 commits intoangular:mainfrom Jan 6, 2026
Merged
fix(core): sanitize sensitive attributes on SVG script elements#66318kirjs merged 2 commits intoangular:mainfrom
kirjs merged 2 commits intoangular:mainfrom
Conversation
e8bbc98 to
9776ff7
Compare
Contributor
Author
josephperrott
approved these changes
Jan 5, 2026
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
AndrewKushnir
approved these changes
Jan 5, 2026
jelbourn
reviewed
Jan 5, 2026
This commit updates the DOM security schema and sanitization logic to properly recognize and sanitize `href` and `xlink:href` attributes on SVG `<script>` elements. Previously, these attributes were not treated as resource URLs, which could allow for Cross-Site Scripting (XSS) if attacker-controlled values were interpolated into them.
329b985 to
c8acbf8
Compare
jelbourn
approved these changes
Jan 6, 2026
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
This was referenced Jan 10, 2026
Open
This was referenced Jan 10, 2026
Open
core-5.2.11.tgz: 3 vulnerabilities (highest severity is: 8.1)
nexmo-community/nexmo-stitch-angular#1
Open
Open
Open
compiler-cli-9.1.13.tgz: 2 vulnerabilities (highest severity is: 8.0)
snowdensb/dependabot-core#1252
Open
Open
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the DOM security schema and sanitization logic to properly recognize and sanitize
hrefandxlink:hrefattributes on SVG<script>elements.Previously, these attributes were not treated as resource URLs, which could allow for Cross-Site Scripting (XSS) if attacker-controlled values were interpolated into them.
Context: http://b/472263766