Skip to content

fix(core): pass element removal property through in all locations #64565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(core): pass element removal property through in all locations #64565

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Oct 21, 2025

The requireSynchronousElementRemoval property was not being passed in all the locations it was needed. This was preventing leave animation timing from behaving properly in some cases.

fixes: #64525

@thePunderWoman
fix(core): pass element removal property through in all locations
759eb92 
The `requireSynchronousElementRemoval` property was not being passed in all the locations it was needed. This was preventing leave animation timing from behaving properly in some cases.

fixes: angular#64525
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Oct 21, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 21, 2025
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2025
@thePunderWoman thePunderWoman removed the request for review from JeanMeche October 21, 2025 17:59
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Oct 21, 2025

This PR was merged into the repository. The changes were merged into the following branches:

thePunderWoman added a commit that referenced this pull request Oct 21, 2025
@thePunderWoman
fix(core): pass element removal property through in all locations (#6…
4c89a26 
…4565)

The `requireSynchronousElementRemoval` property was not being passed in all the locations it was needed. This was preventing leave animation timing from behaving properly in some cases.

fixes: #64525

PR Close #64565
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 21, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

DOM element is not removed when animate.leave is used together with legacy animations

2 participants

@thePunderWoman @AndrewKushnir