fix(forms): only propagate schema defined properties from field to control#64446
Closed
leonsenft wants to merge 4 commits intoangular:mainfrom
Closed
fix(forms): only propagate schema defined properties from field to control#64446leonsenft wants to merge 4 commits intoangular:mainfrom
leonsenft wants to merge 4 commits intoangular:mainfrom
Conversation
a4fd662 to
7b6fab6
Compare
Note that unlike the other built-in properties, `pattern` is not propagated to native controls so the lack of symmetry with other property tests is intentional.
`FormUiControl` is the base type used for shared properties of `FormValueControl` and `FormCheckboxControl`.
…ntrol Prior to this change, `FieldState` defined a signal for each built-in property. This unfortunately meant that the `Field` directive had no way of knowing which property had actually been defined in the schema, and would thus attempt to propagate them all to the bound form control. This meant that the default values of these signals would override the default or template defined values of these control properties. Now these properties are `undefined` by default, and only initialized if defined in the schema. Thus the `Field` directive will not attempt to bind any properties that aren't explicitly managed by the schema.
7b6fab6 to
a1467c0
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Oct 21, 2025
…ntrol (#64446) Prior to this change, `FieldState` defined a signal for each built-in property. This unfortunately meant that the `Field` directive had no way of knowing which property had actually been defined in the schema, and would thus attempt to propagate them all to the bound form control. This meant that the default values of these signals would override the default or template defined values of these control properties. Now these properties are `undefined` by default, and only initialized if defined in the schema. Thus the `Field` directive will not attempt to bind any properties that aren't explicitly managed by the schema. PR Close #64446
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change,
FieldStatedefined a signal for each built-in property. This unfortunately meant that theFielddirective had no way of knowing which property had actually been defined in the schema, and would thus attempt to propagate them all to the bound form control. This meant that the default values of these signals would override the default or template defined values of these control properties.Now these properties are
undefinedby default, and only initialized if defined in the schema. Thus theFielddirective will not attempt to bind any properties that aren't explicitly managed by the schema.