fix(core): fixes regression in animate.leave function bindings#64413
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): fixes regression in animate.leave function bindings#64413thePunderWoman wants to merge 1 commit intoangular:mainfrom
animate.leave function bindings#64413thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
When adding and removing items in a `@for` loop, the `animate.leave` event binding instruction was not updated to use the same logic as the class function when the animation queue was added. We were not returning the correct signature for the `animate.leave` function, which caused the animation to not trigger correctly. This updates the event binding instruction to use the same logic as the class function when adding the animation to the queue. fixes: angular#64336
AndrewKushnir
approved these changes
Oct 14, 2025
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 14, 2025
) When adding and removing items in a `@for` loop, the `animate.leave` event binding instruction was not updated to use the same logic as the class function when the animation queue was added. We were not returning the correct signature for the `animate.leave` function, which caused the animation to not trigger correctly. This updates the event binding instruction to use the same logic as the class function when adding the animation to the queue. fixes: #64336 PR Close #64413
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding and removing items in a
@forloop, theanimate.leaveevent binding instruction was not updated to use the same logic as the class function when the animation queue was added. We were not returning the correct signature for theanimate.leavefunction, which caused the animation to not trigger correctly. This updates the event binding instruction to use the same logic as the class function when adding the animation to the queue.fixes: #64336