perf(compiler-cli): fix performance of "interpolated signal not invok… #64410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed" check This fixes a performance regression from angular#63754, which is almost a revert of the prior performance fix in angular#57291; the latter was provided as quick fix to address the severe performance overhead this extended diagnostic used to have, with angular#57337 as follow-up change to address the false negatives that were introduced in angular#57291. That follow-up never landed, though, so this commit is re-applying the changes from angular#57337 to fix the performance regression. Fixes angular#64403
atscott
approved these changes
Oct 14, 2025
Contributor
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ed" check (#64410) This fixes a performance regression from #63754, which is almost a revert of the prior performance fix in #57291; the latter was provided as quick fix to address the severe performance overhead this extended diagnostic used to have, with #57337 as follow-up change to address the false negatives that were introduced in #57291. That follow-up never landed, though, so this commit is re-applying the changes from #57337 to fix the performance regression. Fixes #64403 PR Close #64410
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed" check
This fixes a performance regression from #63754, which is almost a revert of the prior performance fix in #57291; the latter was provided as quick fix to address the severe performance overhead this extended diagnostic used to have, with #57337 as follow-up change to address the false negatives that were introduced in #57291. That follow-up never landed, though, so this commit is re-applying the changes from #57337 to fix the performance regression.
Fixes #64403