Allow defining application providers in bootstrapModule#64354
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
Allow defining application providers in bootstrapModule#64354atscott wants to merge 2 commits intoangular:mainfrom
bootstrapModule#64354atscott wants to merge 2 commits intoangular:mainfrom
Conversation
…dule This fixes the code to retain ZoneJS by default in the providers for downgradeModule when the `bootstrapModule` is used. Prior to this change, the async `bootstrapModule`/`compileNgModuleFactory` could be called multiple times through `downgradeModule` before `bootstrapModuleFactory` got called and used the zone providers. Note: marked refactor since this only applies to the -next release and we shouldn't have this change in the changelog as a fix.
…options This commit adds `applicationProviders` to the `bootstrapModule` options object. This allows specifying additional providers at the location of bootstrap, which makes default providers much easier to accomplish. Using this, we can refine the approach taken for downgrade_module to use this more direct API rather than the additional provider variable dance.
AndrewKushnir
approved these changes
Oct 13, 2025
AndrewKushnir
approved these changes
Oct 13, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 13, 2025
…options (#64354) This commit adds `applicationProviders` to the `bootstrapModule` options object. This allows specifying additional providers at the location of bootstrap, which makes default providers much easier to accomplish. Using this, we can refine the approach taken for downgrade_module to use this more direct API rather than the additional provider variable dance. PR Close #64354
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Oct 14, 2025
… migration angular#64354 introduced the `applicationProviders` for `bootstrapModule`, this allows a simpler migration output.
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Oct 15, 2025
… migration PR angular#64354 introduced the `applicationProviders` for `bootstrapModule`, this allows a simpler migration output.
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Oct 22, 2025
… migration PR angular#64354 introduced the `applicationProviders` for `bootstrapModule`, this allows a simpler migration output.
crisbeto
pushed a commit
that referenced
this pull request
Oct 27, 2025
… migration PR #64354 introduced the `applicationProviders` for `bootstrapModule`, this allows a simpler migration output.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
applicationProvidersto thebootstrapModuleoptionsobject. This allows specifying additional providers at the location of
bootstrap, which makes default providers much easier to accomplish.
Using this, we can refine the approach taken for downgrade_module to use
this more direct API rather than the additional provider variable dance.
(first commit is in a separate PR and is effectively rolled back by the second)