Skip to content

fix(compiler): correctly compile long numeric HTML entities #64297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SkyZeroZx wants to merge 1 commit into from
Closed

fix(compiler): correctly compile long numeric HTML entities #64297

SkyZeroZx wants to merge 1 commit into from

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Oct 8, 2025 •
edited
Loading

Fixes an issue where long numeric HTML entities (e.g. 🛈) were incorrectly compiled due to the use of 4-digit

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #51274

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SkyZeroZx
fix(compiler): correctly compile long numeric HTML entities
9335833 
Fixes an issue where long numeric HTML entities (e.g. 🛈) were incorrectly compiled due to the use of 4-digit
@pullapprove pullapprove bot requested a review from thePunderWoman October 8, 2025 17:59
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 8, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 8, 2025
@JeanMeche JeanMeche requested a review from crisbeto October 9, 2025 12:23
JeanMeche
JeanMeche reviewed Oct 9, 2025
View reviewed changes
thePunderWoman
thePunderWoman approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 17, 2025
@thePunderWoman thePunderWoman removed the request for review from crisbeto October 17, 2025 18:19
thePunderWoman pushed a commit that referenced this pull request Oct 17, 2025
@SkyZeroZx @thePunderWoman
fix(compiler): correctly compile long numeric HTML entities (#64297)
891f180 
Fixes an issue where long numeric HTML entities (e.g. 🛈) were incorrectly compiled due to the use of 4-digit

PR Close #64297
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Oct 17, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@JoostK JoostK mentioned this pull request Oct 21, 2025
Closed
@JoostK
Copy link
Member

JoostK commented Oct 21, 2025

@SkyZeroZx Could you please start including Closes #xxxx or Fixes #xxxx in commit message footers such that linked issues are properly closed when a PR is merged; having them just in the PR description isn't sufficient and also isn't picked up by Github to link the PR to an open issue:

Screenshot 2025-10-21 at 22 32 23

Including the commit footer avoids all these problems, helping us track issues better.

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 21, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@crisbeto crisbeto crisbeto left review comments

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@SkyZeroZx @thePunderWoman @JoostK @JeanMeche @crisbeto