fix(core): Fixes leave animation behaviors with multiple transitionend events on the same node #64225

thePunderWoman · 2025-10-03T17:45:28Z

See the commits for details, but the TL;DR is below

Fixes host binding tests so that they're testing properly
adds a safeguard for enter animations and handling class removal when no longest animation can be determined
Fixes the case of ensuring that elements are only removed once the longest animation has finished when multiple animations are present on the same element, but also still safely supporting host binding composition.

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases.

…est animation There may be cases where the longest animation info has been cleaned up before the end animation fires. We should still do the end processing in that case.

packages/core/src/animation/utils.ts

…nsitions are present Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: angular#64209

JeanMeche · 2025-10-03T19:57:27Z

packages/core/test/bundling/defer/bundle.golden_symbols.json

      "shimStylesContent"
    ],
    "lazy": [
+      "DeferComponent",


cc @devversion

We often see such a diff where the DeferComponent gets moved around. It there a way to fix that. ?

mmalerba · 2025-10-06T19:34:30Z

This PR was merged into the repository. The changes were merged into the following branches:

main: e279f30
20.3.x: 3b95910

…est animation (#64225) There may be cases where the longest animation info has been cleaned up before the end animation fires. We should still do the end processing in that case. PR Close #64225

…nsitions are present (#64225) Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: #64209 PR Close #64225

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases. PR Close #64225

…est animation (#64225) There may be cases where the longest animation info has been cleaned up before the end animation fires. We should still do the end processing in that case. PR Close #64225

…nsitions are present (#64225) Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: #64209 PR Close #64225

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases. PR Close angular#64225

…nsitions are present (angular#64225) Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: angular#64209 PR Close angular#64225

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases. PR Close angular#64225

…est animation (angular#64225) There may be cases where the longest animation info has been cleaned up before the end animation fires. We should still do the end processing in that case. PR Close angular#64225

…nsitions are present (angular#64225) Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: angular#64209 PR Close angular#64225

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases. PR Close angular#64225

…nsitions are present (angular#64225) Our code ensuring host binding composition for animations was causing the early exit and removal of elements when multiple transitions were present on the same element. This commit fixes the issue by ensuring that we properly keep track of all the promise resolvers on the LView and then only call them once we've properly waited for the longest animation to finish. fixes: angular#64209 PR Close angular#64225

angular-automatic-lock-bot · 2025-11-12T00:12:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

thePunderWoman added 2 commits October 2, 2025 16:30

refactor(core): fix animations host binding tests

d8e695a

These tests were not properly validating against the host binding changes due to the fact that the styles were on the wrong components in some of the host binding cases.

refactor(core): allow animationend to process if we don't have a long…

1d3ce0d

…est animation There may be cases where the longest animation info has been cleaned up before the end animation fires. We should still do the end processing in that case.

thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Oct 3, 2025

ngbot bot added this to the Backlog milestone Oct 3, 2025

thePunderWoman requested a review from AndrewKushnir October 3, 2025 17:55

thePunderWoman force-pushed the host-bindings branch 2 times, most recently from 63c8e87 to 6d222a5 Compare October 3, 2025 17:58

AndrewKushnir reviewed Oct 3, 2025

View reviewed changes

packages/core/src/animation/utils.ts Show resolved Hide resolved

thePunderWoman force-pushed the host-bindings branch from 6d222a5 to ba8ad97 Compare October 3, 2025 19:06

JeanMeche reviewed Oct 3, 2025

View reviewed changes

AndrewKushnir approved these changes Oct 3, 2025

View reviewed changes

thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 3, 2025

mmalerba closed this in a52a2af Oct 6, 2025

dilldin35 approved these changes Oct 12, 2025

View reviewed changes

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): Fixes leave animation behaviors with multiple transitionend events on the same node #64225

fix(core): Fixes leave animation behaviors with multiple transitionend events on the same node #64225

Uh oh!

thePunderWoman commented Oct 3, 2025

Uh oh!

Uh oh!

JeanMeche Oct 3, 2025

Uh oh!

mmalerba commented Oct 6, 2025

Uh oh!

angular-automatic-lock-bot bot commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(core): Fixes leave animation behaviors with multiple transitionend events on the same node #64225

fix(core): Fixes leave animation behaviors with multiple transitionend events on the same node #64225

Uh oh!

Conversation

thePunderWoman commented Oct 3, 2025

Uh oh!

Uh oh!

JeanMeche Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

mmalerba commented Oct 6, 2025

Uh oh!

angular-automatic-lock-bot bot commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants