Skip to content

fix(core): handle undefined CSS time values in parseCssTimeUnitsToMs function #64181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yyasinaslan wants to merge 1 commit into from
Closed

fix(core): handle undefined CSS time values in parseCssTimeUnitsToMs function #64181

yyasinaslan wants to merge 1 commit into from

Conversation

@yyasinaslan
Copy link
Contributor

@yyasinaslan yyasinaslan commented Oct 1, 2025

Improve error handling when rawDelays contains fewer items than transitionedProperties, preventing a toLowerCase of undefined error in parseCssTimeUnitsToMs.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

parseCssTimeUnitsToMs throws "Cannot read properties of undefined" when value parameter is undefined due to not existing index passed.

image

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@yyasinaslan
fix(core): handle undefined CSS time values in parseCssTimeUnitsToMs …
62332a1 
…function

Improve error handling when `rawDelays` contains fewer items than `transitionedProperties`, preventing a toLowerCase of undefined error in `parseCssTimeUnitsToMs`.
@pullapprove pullapprove bot requested a review from mmalerba October 1, 2025 19:02
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 1, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 1, 2025
thePunderWoman
thePunderWoman approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 2, 2025
@mmalerba
Copy link
Contributor

mmalerba commented Oct 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@mmalerba mmalerba closed this in cb56fbf Oct 2, 2025
mmalerba pushed a commit that referenced this pull request Oct 2, 2025
@yyasinaslan @mmalerba
fix(core): handle undefined CSS time values in parseCssTimeUnitsToMs …
76fe559 
…function (#64181)

Improve error handling when `rawDelays` contains fewer items than `transitionedProperties`, preventing a toLowerCase of undefined error in `parseCssTimeUnitsToMs`.

PR Close #64181
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
@yyasinaslan
fix(core): handle undefined CSS time values in parseCssTimeUnitsToMs …
387849b 
…function (angular#64181)

Improve error handling when `rawDelays` contains fewer items than `transitionedProperties`, preventing a toLowerCase of undefined error in `parseCssTimeUnitsToMs`.

PR Close angular#64181
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 2, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@yyasinaslan @mmalerba @thePunderWoman @JeanMeche