feat(core): support IntersectionObserver options in viewport triggers#64130
Closed
crisbeto wants to merge 6 commits intoangular:mainfrom
Closed
feat(core): support IntersectionObserver options in viewport triggers#64130crisbeto wants to merge 6 commits intoangular:mainfrom
crisbeto wants to merge 6 commits intoangular:mainfrom
Conversation
b7057e9 to
8546617
Compare
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Is there any particular reason why the IntersectionObserver options must be a static object literal and cannot be dynamic, for example by using signals to customize them at runtime? |
Member
Author
|
It's because the |
…ters Currently we produce the string value of a defer `on` trigger by concatenating the string values of all of its tokens. This ends up ignoring whitespaces which in turn throws off source spans. These changes switch to producing the string by taking the text between the start and end tokens, as well as tracking the start index.
Updates the template parser and AST to capture a second object literal parameter on `viewport` triggers.
Updates the template type checker to check the options of the `viewport` trigger against `IntersectionObserver`.
Updates the template pipeline to support options for the `viewport` triggers.
8546617 to
9804ce7
Compare
| expect(diags.length).toBe(1); | ||
| expect(diags[0].messageText).toBe( | ||
| 'Trigger with no parameters can only be placed on an @defer that has a @placeholder block', | ||
| 'Trigger with no target can only be placed on an @defer that has a @placeholder block', |
thePunderWoman
approved these changes
Oct 3, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM
Just a couple of small comments.
Adds support for customizing the `IntersectionObserver` options for the `on viewport`, `prefetch on viewport` and `hydrate on viewport` triggers.
Note that the options need to be a static object literal, e.g. `@defer (on viewport(trigger, {rootMargin: '123px'})`.
Fixes angular#52799.
Updates the docs to mention the new options for the `viewport` trigger.
b88d4b0 to
3ce33ed
Compare
Member
Author
mturco
approved these changes
Oct 6, 2025
Contributor
mturco
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: primitives-shared
Member
Author
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
) Updates the template parser and AST to capture a second object literal parameter on `viewport` triggers. PR Close #64130
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
Updates the template type checker to check the options of the `viewport` trigger against `IntersectionObserver`. PR Close #64130
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
) Updates the template pipeline to support options for the `viewport` triggers. PR Close #64130
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
…#64130) Adds support for customizing the `IntersectionObserver` options for the `on viewport`, `prefetch on viewport` and `hydrate on viewport` triggers. Note that the options need to be a static object literal, e.g. `@defer (on viewport(trigger, {rootMargin: '123px'})`. Fixes #52799. PR Close #64130
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
Updates the docs to mention the new options for the `viewport` trigger. PR Close #64130
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for customizing the
IntersectionObserveroptions for theon viewport,prefetch on viewportandhydrate on viewporttriggers.Note that the options need to be a static object literal, e.g.
@defer (on viewport({trigger, rootMargin: '123px'}).Fixes #52799.