refactor(common): improve typing of ngComponentOutletContent#63674
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(common): improve typing of ngComponentOutletContent#63674JeanMeche wants to merge 1 commit intoangular:mainfrom
ngComponentOutletContent#63674JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
Dropping `any` in favor of `Node` for better type safety and clarity. BREAKING CHANGE: `ngComponentOutletContent` is now of type `Node[][] | undefined` instead of `any[][] | undefined`. fixes angular#63538
5a6416d to
a1c0727
Compare
Member
Author
atscott
approved these changes
Sep 10, 2025
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
thePunderWoman
approved these changes
Sep 10, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: fw-general, public-api
Contributor
|
@JeanMeche I think this needs a commit message tweak so that the |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
ngComponentOutletContentis now of typeNode[][] | undefinedinstead ofany[][]fixes #63538