fix(platform-server): prevent false warning for duplicate state serialization#63525
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
fix(platform-server): prevent false warning for duplicate state serialization#63525alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
…lization The `TRANSFER_STATE_SERIALIZED_FOR_APPID` provider was previously configured at the platform level, causing its state to be shared across all concurrent server-side rendering requests. This created a race condition where one request could see the `appId` from a different, concurrent request, leading to false warnings about duplicate state serialization. This commit changes the provider's scope to ensure that each application instance gets its own unique state. This correctly isolates the serialization check to each individual request, resolving the issue of false warnings in concurrent environments. Closes angular#63524
…king The logic to track if the transfer state has been serialized is simplified by removing the need for `APP_ID`. Instead of maintaining a `Set` of application IDs, a simple boolean flag is used.
Contributor
Author
|
This got me thinking as the platform should actually not be shared among different requests. The problem is which is not safe for concurrent request. However, right now there is no easy way to get around this. |
NothingEverHappens
approved these changes
Sep 3, 2025
Contributor
NothingEverHappens
left a comment
There was a problem hiding this comment.
reviewed-for: general
JeanMeche
approved these changes
Sep 3, 2025
Contributor
mmalerba
pushed a commit
that referenced
this pull request
Sep 3, 2025
…lization (#63525) The `TRANSFER_STATE_SERIALIZED_FOR_APPID` provider was previously configured at the platform level, causing its state to be shared across all concurrent server-side rendering requests. This created a race condition where one request could see the `appId` from a different, concurrent request, leading to false warnings about duplicate state serialization. This commit changes the provider's scope to ensure that each application instance gets its own unique state. This correctly isolates the serialization check to each individual request, resolving the issue of false warnings in concurrent environments. Closes #63524 PR Close #63525
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TRANSFER_STATE_SERIALIZED_FOR_APPIDprovider was previously configured at the platform level, causing its state to be shared across all concurrent server-side rendering requests. This created a race condition where one request could see theappIdfrom a different, concurrent request, leading to false warnings about duplicate state serialization.This commit changes the provider's scope to ensure that each application instance gets its own unique state. This correctly isolates the serialization check to each individual request, resolving the issue of false warnings in concurrent environments.
Closes #63524