fix(core): Prevent an error on cleanup when an rxResource stream threw before returning an Observable#63342
Closed
wartab wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Prevent an error on cleanup when an rxResource stream threw before returning an Observable#63342wartab wants to merge 1 commit intoangular:mainfrom
rxResource stream threw before returning an Observable#63342wartab wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
reviewed
Aug 22, 2025
Comment on lines
+81
to
+90
| it('should cleanup without error when the stream function threw an error', async () => { | ||
| const injector = Injector.create({ | ||
| providers: [], | ||
| parent: TestBed.inject(Injector), | ||
| }); | ||
| const appRef = TestBed.inject(ApplicationRef); | ||
| const res = rxResource({ | ||
| stream: () => { | ||
| throw 'oh no'; | ||
| }, | ||
| injector, | ||
| }); | ||
| await appRef.whenStable(); | ||
|
|
||
| // What now? :( | ||
| }); |
Member
There was a problem hiding this comment.
Suggested change
| it('should cleanup without error when the stream function threw an error', async () => { | |
| const injector = Injector.create({ | |
| providers: [], | |
| parent: TestBed.inject(Injector), | |
| }); | |
| const appRef = TestBed.inject(ApplicationRef); | |
| const res = rxResource({ | |
| stream: () => { | |
| throw 'oh no'; | |
| }, | |
| injector, | |
| }); | |
| await appRef.whenStable(); | |
| // What now? :( | |
| }); | |
| it('should cleanup without error when the stream function threw an error', async () => { | |
| const appRef = TestBed.inject(ApplicationRef); | |
| const res = rxResource({ | |
| stream: () => { | |
| throw 'oh no'; | |
| }, | |
| injector: appRef.injector, | |
| }); | |
| await appRef.whenStable(); | |
| }); |
This basically throws today, but shouldn't with your fix.
Contributor
Author
|
From my understanding, this is actually not what happens. Because if you look at the StackBlitz from my issue, the code itself doesn't throw. The resource is created and is in an error state. |
Member
|
What I mean is that the test fails because a runtime error is thrown while awaiting. With your fix the test should pass without any expectations. |
…threw before returning an `Observable` Before this commit, it was wrongly assumed that the stream subscription could not be `undefined`. Fixes angular#63341
3b1dfab to
4a1e0cd
Compare
JeanMeche
approved these changes
Aug 26, 2025
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, it was wrongly assumed that the stream subscription could not be
undefined.Fixes #63341
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #63341
What is the new behavior?
No error
Does this PR introduce a breaking change?
Other information
Please suggest a way to write this test :(