fix(core): fix animation behavior on @for loops#63328
Closed
thePunderWoman wants to merge 2 commits intoangular:mainfrom
Closed
fix(core): fix animation behavior on @for loops#63328thePunderWoman wants to merge 2 commits intoangular:mainfrom
@for loops#63328thePunderWoman wants to merge 2 commits intoangular:mainfrom
Conversation
This ensures the nodes are properly cleaned up from the leaving nodes map.
@for loops
454429c to
029c261
Compare
crisbeto
reviewed
Aug 22, 2025
da144b2 to
96dd7a9
Compare
JeanMeche
reviewed
Aug 22, 2025
96dd7a9 to
bf0de1c
Compare
crisbeto
approved these changes
Aug 22, 2025
There's special logic in place to prevent duplicate nodes from showing up in the case when an `@if` toggles a view quickly. This had the unfortunate side effect of causing `@for` leave animations to get cancelled when an add and remove happened simultaneously, even if it was a different index. This fix prevents that from happening in the `@for` loop case. fixes: angular#63307
bf0de1c to
7e32d9c
Compare
crisbeto
approved these changes
Aug 22, 2025
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 22, 2025
This ensures the nodes are properly cleaned up from the leaving nodes map. PR Close #63328
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 22, 2025
There's special logic in place to prevent duplicate nodes from showing up in the case when an `@if` toggles a view quickly. This had the unfortunate side effect of causing `@for` leave animations to get cancelled when an add and remove happened simultaneously, even if it was a different index. This fix prevents that from happening in the `@for` loop case. fixes: #63307 PR Close #63328
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 22, 2025
There's special logic in place to prevent duplicate nodes from showing up in the case when an `@if` toggles a view quickly. This had the unfortunate side effect of causing `@for` leave animations to get cancelled when an add and remove happened simultaneously, even if it was a different index. This fix prevents that from happening in the `@for` loop case. fixes: #63307 PR Close #63328
arvindsc
approved these changes
Sep 4, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
@forloops added and removed an element in the same change detection cycle, the duplicate node prevention would cause the leaving node animation to be cancelled. This fix prevents cancellation of leave animations in@forloops. It also fixes a memory leak where nodes weren't properly getting cleaned up from the leaving nodes map.Does this PR introduce a breaking change?