Skip to content

fix(compiler): fixes animation event host bindings not firing#63217

Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:animate-event
Closed

fix(compiler): fixes animation event host bindings not firing#63217
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:animate-event

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman commented Aug 18, 2025

Host bindings for (animate.enter) and (animate.leave) were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: #63199

  • Yes
  • No

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate labels Aug 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 18, 2025
crisbeto
crisbeto reviewed Aug 18, 2025
View reviewed changes
@thePunderWoman
fix(compiler): fixes animation event host bindings not firing
c018748 
Host bindings for `(animate.enter)` and `(animate.leave)` were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: angular#63199
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Aug 18, 2025
@ngbot
Copy link
Copy Markdown

ngbot bot commented Aug 18, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman
Copy link
Copy Markdown
Contributor Author

thePunderWoman commented Aug 18, 2025

This PR was merged into the repository by commit cab3adf.

The changes were merged into the following branches: main, 20.2.x

thePunderWoman added a commit that referenced this pull request Aug 18, 2025
@thePunderWoman
fix(compiler): fixes animation event host bindings not firing (#63217)
7b51728 
Host bindings for `(animate.enter)` and `(animate.leave)` were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: #63199

PR Close #63217
@thePunderWoman thePunderWoman deleted the animate-event branch September 12, 2025 16:38
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 13, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Provide hostbinding for (animate.enter) and (animate.leave) events

2 participants

@thePunderWoman @crisbeto