fix(compiler): incorrect spans for AST inside input value with leading space#63082
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): incorrect spans for AST inside input value with leading space#63082crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…g space When parsing expressions inside a bound attribute, we offset all of its spans by an `absoluteOffset` in order to get the right spans in the source file. The offset was incorrect when parsing an attribute with leading spaces during the construction of the Ivy AST, because of the combination of: 1. We were setting the offset by looking at `valueSpan.start`. 2. The Ivy parser sets `leadingTriviaChars: [' ', '\n']` which means that spaces and new lines will be ignored in the `sourceSpan.start`. These changes resolve the issue by using `valueSpan.fullStart` which includes the leading spaces. Fixes angular#63069.
JoostK
approved these changes
Aug 11, 2025
atscott
pushed a commit
that referenced
this pull request
Aug 11, 2025
…g space (#63082) When parsing expressions inside a bound attribute, we offset all of its spans by an `absoluteOffset` in order to get the right spans in the source file. The offset was incorrect when parsing an attribute with leading spaces during the construction of the Ivy AST, because of the combination of: 1. We were setting the offset by looking at `valueSpan.start`. 2. The Ivy parser sets `leadingTriviaChars: [' ', '\n']` which means that spaces and new lines will be ignored in the `sourceSpan.start`. These changes resolve the issue by using `valueSpan.fullStart` which includes the leading spaces. Fixes #63069. PR Close #63082
Contributor
|
This PR was merged into the repository by commit d17555a. The changes were merged into the following branches: main, 20.1.x, 20.2.x |
atscott
pushed a commit
that referenced
this pull request
Aug 11, 2025
…g space (#63082) When parsing expressions inside a bound attribute, we offset all of its spans by an `absoluteOffset` in order to get the right spans in the source file. The offset was incorrect when parsing an attribute with leading spaces during the construction of the Ivy AST, because of the combination of: 1. We were setting the offset by looking at `valueSpan.start`. 2. The Ivy parser sets `leadingTriviaChars: [' ', '\n']` which means that spaces and new lines will be ignored in the `sourceSpan.start`. These changes resolve the issue by using `valueSpan.fullStart` which includes the leading spaces. Fixes #63069. PR Close #63082
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 15, 2025
…te attribute Similar fix as angular#63082, but for template attributes. The root cause is the same where we should be using `fullStart` instead of `start` in order to account for whitespaces being skipped. Fixes angular#63157.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing expressions inside a bound attribute, we offset all of its spans by an
absoluteOffsetin order to get the right spans in the source file. The offset was incorrect when parsing an attribute with leading spaces during the construction of the Ivy AST, because of the combination of:valueSpan.start.leadingTriviaChars: [' ', '\n']which means that spaces and new lines will be ignored in thesourceSpan.start.These changes resolve the issue by using
valueSpan.fullStartwhich includes the leading spaces.Fixes #63069.