Skip to content

fix(compiler-cli): error when type checking host bindings of generic directive#63061

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:63052/host-bindings-generic-error
Closed

fix(compiler-cli): error when type checking host bindings of generic directive#63061
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:63052/host-bindings-generic-error

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Aug 8, 2025

Fixes that the compiler was throwing an error if type checking of host bindings is enabled for a generic directive. The problem was that we were always using the TcbNonGenericDirectiveTypeOp.

Fixes #63052.

…directive

Fixes that the compiler was throwing an error if type checking of host bindings is enabled for a generic directive. The problem was that we were always using the `TcbNonGenericDirectiveTypeOp`.

Fixes angular#63052.
@crisbeto crisbeto requested a review from devversion August 8, 2025 07:19
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 8, 2025
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Aug 8, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 8, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 8, 2025
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Aug 8, 2025

This PR was merged into the repository by commit c77e519.

The changes were merged into the following branches: main, 20.1.x

@atscott atscott closed this in c77e519 Aug 8, 2025
atscott pushed a commit that referenced this pull request Aug 8, 2025
…directive (#63061)

Fixes that the compiler was throwing an error if type checking of host bindings is enabled for a generic directive. The problem was that we were always using the `TcbNonGenericDirectiveTypeOp`.

Fixes #63052.

PR Close #63061
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular Language Service keeps crashing when using host and generic with host type-checking

3 participants