feat(router): convert lastSuccessfulNavigation to signal#63057
feat(router): convert lastSuccessfulNavigation to signal#63057JeanMeche wants to merge 1 commit intoangular:mainfrom
lastSuccessfulNavigation to signal#63057Conversation
3046187 to
30373f0
Compare
|
The patch CL to submit alongside this PR: https://critique.corp.google.com/cl/793706017 |
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
This commit also include an `ng update` migration to ensure `lastSuccessfulNavigation` is invoked. BREAKING CHANGE: `lastSuccessfulNavigation` is now a signal and needs to be invoked
30373f0 to
9117590
Compare
|
This PR was merged into the repository by commit 4e0fc81. The changes were merged into the following branches: main |
|
@JeanMeche I noticed a change in the behavior of On a direct page visit (the initial navigation), the Is this new behavior intentional and an expected part of the new signal-based API? I couldn't find info of this specific behavior in the PR, so I wanted to confirm. Thank you for the clarification. |
|
@IgorSedov Do you have a reproduction? There were no changes to the timing of the updates in this CL |
|
@atscott My bad. Thanks for the quick response. I found the problem on my end. I tested in different configurations (SSR, Zoneless, v20/v21) and everything is fine. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit also include an
ng updatemigration to ensurelastSuccessfulNavigationis invoked.BREAKING CHANGE:
lastSuccessfulNavigationis now a signal and needs to be invoked