fix(compiler-cli): Ignore diagnostics on ngTemplateContextGuard lines…#63054
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): Ignore diagnostics on ngTemplateContextGuard lines…#63054atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
… in TCB
Deprecated diagnostics can appear on the context guard becaues the
directive itself may be deprecated.
For example, context guards look like `if (i1.NgForOf.ngTemplateContextGuard(_t8, _t9) /*331,378*/) {...}`
and typescript will report the deprecation on the whole element, from
start to end tag, because the span for that node includes it.
fixes angular/vscode-ng-language-service#2203
clydin
approved these changes
Aug 7, 2025
Contributor
Author
|
This PR was merged into the repository by commit 812463c. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in TCB
Deprecated diagnostics can appear on the context guard becaues the directive itself may be deprecated.
For example, context guards look like
if (i1.NgForOf.ngTemplateContextGuard(_t8, _t9) /*331,378*/) {...}and typescript will report the deprecation on the whole element, from start to end tag, because the span for that node includes it.fixes angular/vscode-ng-language-service#2203