fix(core): prevents duplicate nodes when @if toggles or @for adds and removes with leave animations#63048
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): prevents duplicate nodes when @if toggles or @for adds and removes with leave animations#63048thePunderWoman wants to merge 1 commit intoangular:mainfrom
@if toggles or @for adds and removes with leave animations#63048thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
reviewed
Aug 7, 2025
4d04ff0 to
a374dac
Compare
@if toggles with leave animations@if toggles or @for adds and removes with leave animations
…mations In the case that a leave animation is running and someone toggles an `@if`, a new node would be inserted. For a brief moment, there may be two of the same nodes visible at once. While this is expected with native CSS, it's not ideal. Instead, we retain a reference to the leaving element and can remove that node when the new node is entering. fixes: angular#63020
a374dac to
4146c43
Compare
crisbeto
approved these changes
Aug 8, 2025
Contributor
|
This PR was merged into the repository by commit 6a11846. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case that a leave animation is running and someone toggles an
@if, a new node would be inserted. For a brief moment, there may be two of the same nodes visible at once. While this is expected with native CSS, it's not ideal. Instead, we retain a reference to the leaving element and can remove that node when the new node is entering.fixes: #63020