Skip to content

fix(core): destroying the effect node on afterRenderEffect#63001

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:leak-after-render-effect
Closed

fix(core): destroying the effect node on afterRenderEffect#63001
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:leak-after-render-effect

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Aug 5, 2025

Prior to this commit, the effect node wasn't destroyed.

fixes #62980

@pullapprove pullapprove bot requested a review from mmalerba August 5, 2025 00:42
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 5, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 5, 2025
@JeanMeche JeanMeche requested review from alxhub and milomg and removed request for mmalerba August 5, 2025 01:53
@JeanMeche JeanMeche changed the title fix(core): destroying the effect on afterRenderEffect fix(core): destroying the effect node on afterRenderEffect Aug 5, 2025
@JeanMeche JeanMeche force-pushed the leak-after-render-effect branch from b5cfbfb to 818bd14 Compare August 5, 2025 02:57
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 6, 2025
@JeanMeche
fix(core): destroying the effect on afterRenderEffect
37b3833 
Prior to this commit, the effect node wasn't destroyed.

fixes angular#62980
@JeanMeche JeanMeche force-pushed the leak-after-render-effect branch from 818bd14 to 37b3833 Compare August 6, 2025 13:38
thePunderWoman
thePunderWoman approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thePunderWoman thePunderWoman removed the request for review from alxhub August 7, 2025 10:38
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 7, 2025
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Aug 8, 2025

This PR was merged into the repository by commit 85d51a3.

The changes were merged into the following branches: main, 20.1.x

@atscott atscott closed this in 85d51a3 Aug 8, 2025
atscott pushed a commit that referenced this pull request Aug 8, 2025
@JeanMeche @atscott
fix(core): destroying the effect on afterRenderEffect (#63001)
322042c 
Prior to this commit, the effect node wasn't destroyed.

fixes #62980

PR Close #63001
@JeanMeche JeanMeche deleted the leak-after-render-effect branch August 29, 2025 00:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 29, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

+1 more reviewer

@milomg milomg milomg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

afterRenderEffect leaks signal reads

4 participants

@JeanMeche @atscott @thePunderWoman @milomg