fix(core): properly recognize failed fetch responses when loading external resources in JIT#62992
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): properly recognize failed fetch responses when loading external resources in JIT#62992devversion wants to merge 1 commit intoangular:mainfrom
fetch responses when loading external resources in JIT#62992devversion wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Aug 4, 2025
…xternal resources in JIT Currently when loading external resources in JIT, when `fetch` fails, the `text` is empty and the component is loading. This hides the actual underlying fetch error. We should properly detect this and error out.
4619375 to
8bfd8a6
Compare
jelbourn
approved these changes
Aug 4, 2025
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
Member
Author
|
Caretaker note: This has a passing TGP |
Member
|
This PR was merged into the repository by commit 648bbb0. The changes were merged into the following branches: main, 20.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when loading external resources in JIT, when
fetchfails, thetextis empty and the component is loading. This hides the actual underlying fetch error. We should properly detect this and error out.